Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hessian corner detector #364

Merged
merged 11 commits into from
Aug 21, 2019
Merged

Hessian corner detector #364

merged 11 commits into from
Aug 21, 2019

Commits on Aug 21, 2019

  1. Hessian plain determinant 

    This commit partially implements
Hessian corner detector, but only
uses determinant as Hessian response
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    2b40c82 View commit details
    Browse the repository at this point in the history

  2. Implement full Hessian corner detector 

    This commit complements last one
by summing in a window and applying
det - k * trace * trace formula to
final Hessian response
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    238d124 View commit details
    Browse the repository at this point in the history

  3. Add docs and make code align with docs 

    This commit adds docs to new functions,
and makes function and variable names
align with docs to not confuse readers
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    e040b74 View commit details
    Browse the repository at this point in the history

  4. Use determinant as response function 

    A-KAZE uses only determinant in it's
response, and since for now Hessian
is only a mean to advance A-KAZE
implementation, response function is
adjusted to use only determinant
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    688167d View commit details
    Browse the repository at this point in the history

  5. Create simple test for Hessian detector 

    This commit adds an s at the end of
function name to make it uniform with
another detector, and adds a simple
test for sanity check
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    6f439d9 View commit details
    Browse the repository at this point in the history

  6. Improve documentations for d params 

    dx and similar naming seems to be
confusing, improved documentation
to explain the naming convention
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    f96df0d View commit details
    Browse the repository at this point in the history

  7. Address minor comments about style

    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    8683b63 View commit details
    Browse the repository at this point in the history

  8. Address type based issues 

    Mostly changes to constness and
integral types, with small cosmetic
changes mixed in
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    8ee318a View commit details
    Browse the repository at this point in the history

  9. Fix typo and address review comment 

    Fixes typo in call for Hessian and
addresses a review comment about
replacing multiple exact indexing
calls to one with a reference
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    7585665 View commit details
    Browse the repository at this point in the history

  10. Reorder includes in Hessian example

    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    9370e3d View commit details
    Browse the repository at this point in the history

  11. Address review comments 

    Add literature reference to luminosity
computation, and perform some cosmetic
changes.
    @simmplecoder
    simmplecoder committed Aug 21, 2019
    Configuration menu
    Copy the full SHA
    b232d89 View commit details
    Browse the repository at this point in the history