Skip to content

Commit

Permalink
digest jar file instead jar path (#678)
Browse files Browse the repository at this point in the history
In the original source, files extracted from the old jar are cached, preventing you the new jar file contents from adding to fileset, Even if the artifact is changed.
  • Loading branch information
ajchemist authored and martinklepsch committed Jan 9, 2018
1 parent 260fe1d commit 58cf82f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ and `technomancy` for the above explanation.
- Boot is officially Maven Central compatible. Make sure the `sources` and `javadoc` artifacts are on the fileset and `:classifier` is correctly set.
- Environment variables BOOT_AS_ROOT, BOOT_WATCHERS_DISABLE und BOOT_COLOR accept `true` as a truthy value beside `1` and `yes` [#631][631]
- Bump [pomegranate](https://github.com/cemerick/pomegranate) and [dynapath](https://github.com/tobias/dynapath) to `1.0.0`. [#612][612]
- Digest `java.io.File` instead `String` path of jar at sift-action `:add-jar` method [#678][678]

#### Fixed

Expand All @@ -47,6 +48,7 @@ and `technomancy` for the above explanation.
[566]: https://github.com/boot-clj/boot/pull/566
[631]: https://github.com/boot-clj/boot/issues/631
[612]: https://github.com/boot-clj/boot/pull/612
[678]: https://github.com/boot-clj/boot/pull/678

## 2.7.2

Expand Down
2 changes: 1 addition & 1 deletion boot/core/src/boot/task_helpers.clj
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
excl (when v? [regex])
jar (jar-path sym)]
(core/add-cached-resource
fs (digest/md5 jar) (partial pod/unpack-jar jar)
fs (digest/md5 (io/file jar)) (partial pod/unpack-jar jar)
:include incl :exclude excl :mergers pod/standard-jar-mergers)))
(reduce fileset args))))

Expand Down

0 comments on commit 58cf82f

Please sign in to comment.