Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digest jar file instead jar path #678

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Conversation

ajchemist
Copy link
Contributor

In the original source, files extracted from the old jar are cached, preventing you the new jar file contents from adding to fileset, Even if the artifact is changed.

@ajchemist ajchemist changed the title digest jar file instead jar path in :add-jar sift-action digest jar file instead jar path Jan 2, 2018
Copy link
Member

@martinklepsch martinklepsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[deleted]

Copy link
Member

@martinklepsch martinklepsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sensible improvement, looks good to me! 👍

@martinklepsch
Copy link
Member

@ajchemist hey, sorry for just noticing now, would you mind adding a line to the changelog file?

In the original source, files extracted from the old jar are cached, preventing you the new jar file contents from adding to fileset, Even if the artifact is changed.
@ajchemist
Copy link
Contributor Author

@martinklepsch ping!

@martinklepsch martinklepsch merged commit 58cf82f into boot-clj:master Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants