feat: implement visitFileFailed for mkvisitor #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
Deraen
requested changes
May 2, 2017
| (visitFileFailed [^Path path ^java.io.IOException e] | ||
| (with-let [_ fs/skip-subtree] | ||
| (let [p (str (.relativize root path))] | ||
| (util/dbug* "Tmpdir: failed to visit: %s\n" (.toString p)))))))) |
There was a problem hiding this comment.
A minor thing: Now that .relativize call is outside of the dbug* macro call, it is evaluated always. If it was inside the macro call, if would be evaluated only when dbug output is enabled.
Also, it is unnecessary to have both str and .toString calls.
|
This looks good. @thenonameguy when you have a chance, in addition to the changes @Deraen mentioned, could you please also add to Thanks! |
|
closing in favor of #629 |
martinklepsch
added a commit
that referenced
this pull request
Jul 11, 2017
martinklepsch
added a commit
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
This project does a treewalk on our project structure, which contains folders/files that cannot be opened by the boot process, this causes the process to exit.
This PR fixes this issue by ignoring these files/directories.