Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement visitFileFailed for mkvisitor #629

Merged
merged 3 commits into from
Sep 26, 2017
Merged

Implement visitFileFailed for mkvisitor #629

merged 3 commits into from
Sep 26, 2017

Conversation

martinklepsch
Copy link
Member

@martinklepsch martinklepsch commented Jul 11, 2017 •
edited
Loading

addressing Juho's feedback and adding an entry to the changelog /via #598

@martinklepsch martinklepsch mentioned this pull request Jul 11, 2017
Closed
@martinklepsch martinklepsch added this to the next-release milestone Jul 11, 2017
Deraen
Deraen approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@Deraen Deraen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why with-let macro is used here (or in visitFile method), but should work.

@martinklepsch
Copy link
Member Author

Just rebased against master.

@Deraen Deraen merged commit ef42889 into master Sep 26, 2017
@arichiardi arichiardi deleted the 598-2 branch September 26, 2017 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deraen Deraen Deraen approved these changes

@arichiardi arichiardi Awaiting requested review from arichiardi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next-release
Development

Successfully merging this pull request may close these issues.
2 participants
@martinklepsch @Deraen