Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Update Metadata service for Java 17 #351

Closed
10 tasks done
jacksondelametter opened this issue Sep 19, 2024 · 2 comments · Fixed by #424
Closed
10 tasks done

Feature: Update Metadata service for Java 17 #351

jacksondelametter opened this issue Sep 19, 2024 · 2 comments · Fixed by #424
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jacksondelametter
Copy link
Contributor

jacksondelametter commented Sep 19, 2024

Description

Follow on to #133, where we want to migrate our whole repository to java 17. This issue will focus on migrating the metadata modules to enable provenance within downstream projects.

Definition of Done

  • Update the following submodules to build with JDK 17
    • foundation-metadata-core
    • foundation-metadata-producer
    • extensions-metadata-service
    • aissemble-metadata (docker)
  • Ensure all pom dependencies are compatible
    • Update to jakarta if applicable
    • Update to official java 17 version if applicable
  • Clean up pom to remove unnecessary dependencies and add undeclared transient dependencies
    • Use mvn dependency:analyze

Test Strategy/Script

  • Update your machine to build with JDK 17. Run mvn -v to verify it's configured properly. The output should be similar to the following (Note: java distributions different thank openjdk are okay):
$ mvn -v
Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
Maven home: /path/to/apache-maven-3.9.6-bin/3311e1d4/apache-maven-3.9.6
Java version: 17.0.8.1, vendor: Private Build, runtime: /usr/lib/jvm/java-17-openjdk-amd64
  • OTS Only:

    • Within the aiSSEMBLE repo, run the following and verify it builds successfully:
    mvn clean install -pl :aissemble-metadata,:foundation-metadata-producer,:foundation-archetype -am -Dmaven.build.cache.skipCache
    
  • Create a downstream project:

mvn archetype:generate -U -DarchetypeGroupId=com.boozallen.aissemble \
  -DarchetypeArtifactId=foundation-archetype \
  -DarchetypeVersion=1.10.0-SNAPSHOT \
  -DgroupId=com.test \
  -DartifactId=test-351 \
  -DprojectGitUrl=test.url \
  -DprojectName=test-351 \
  && cd test-351
  • Add the attached SparkPipelineMetadata.json to the test-351-pipeline-models/src/main/resources/pipelines/ directory

  • Run mvn clean install until all the manual actions are complete

  • Run mvn clean install -Dmaven.build.cache.skipCache to get any remaining manual actions

  • OTS Only:

    • Add the following to test-351-deploy/src/main/resources/apps/metadata/values.yaml:
    aissemble-metadata-chart:
      image:
        imagePullPolicy: IfNotPresent
    
  • tilt up

  • Wait for all the resources to be ready on the tilt ui

  • In a separate terminal, run the following:

curl -X GET http://localhost:8082/metadata/healthcheck
  • Verify it returns the following:
Metadata service is running...
  • Start the spark-pipeline-metadata resource and wait for it to complete
  • Wait until the metadata resource logs the following (Note: VertxException: Thread blocked are expected):
INFO HiveMetadataAPIService: Metadata saved
  • In a separate terminal, run the following:
curl -X GET http://localhost:8082/metadata
  • Verify it returns the following:
[{"resource":"Unspecified TestSyncStep resource","subject":"synchronous","action":"TestSyncStep","timestamp":"CURRENT_TIME_STAMP","additionalValues":{}}]

References/Additional Context

@jacksondelametter jacksondelametter added the bug Something isn't working label Sep 19, 2024
@jacksondelametter jacksondelametter changed the title BUG: JDK 17 Upgrade Support - Build extensions-metadata-service BUG: JDK 17 Upgrade Support Series - Build extensions-metadata-service Sep 19, 2024
@jacksondelametter jacksondelametter changed the title BUG: JDK 17 Upgrade Support Series - Build extensions-metadata-service FEATURE: JDK 17 Upgrade Support Series - Build extensions-metadata-service Sep 19, 2024
@jacksondelametter jacksondelametter added enhancement New feature or request and removed bug Something isn't working labels Sep 19, 2024
@ewilkins-csi ewilkins-csi changed the title FEATURE: JDK 17 Upgrade Support Series - Build extensions-metadata-service FEATURE: JDK 17 Upgrade Support Series - Metadata Service Sep 19, 2024
@ewilkins-csi ewilkins-csi added this to the 1.10.0 milestone Sep 20, 2024
@jacksondelametter jacksondelametter removed their assignment Sep 20, 2024
@carter-cundiff carter-cundiff changed the title FEATURE: JDK 17 Upgrade Support Series - Metadata Service FEATURE: Update Metadata service for Java 17 Oct 15, 2024
@carter-cundiff carter-cundiff self-assigned this Oct 15, 2024
@carter-cundiff carter-cundiff changed the title FEATURE: Update Metadata service for Java 17 Feature: Update Metadata service for Java 17 Oct 15, 2024
@carter-cundiff
Copy link
Contributor

OTS with @jacksondelametter

@carter-cundiff carter-cundiff linked a pull request Oct 18, 2024 that will close this issue
carter-cundiff added a commit that referenced this issue Oct 18, 2024
#351 Update metadata to be compatible with Java 17
@ewilkins-csi
Copy link
Contributor

Final Test passed ✅

  • Health check:
    Screenshot 2024-10-18 at 5 01 26 PM
  • Metadata saved:
    Screenshot 2024-10-18 at 5 11 52 PM
  • Metadata fetched:
    Screenshot 2024-10-18 at 5 12 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants