#415 Ensure data access is compatible with JDK17 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
carter-cundiff
approved these changes
Oct 17, 2024
| <dependency> | ||
| <groupId>org.apache.kafka</groupId> | ||
| <artifactId>kafka-clients</artifactId> | ||
| <version>2.8.1</version> | ||
| <version>${version.kafka.client}</version> |
There was a problem hiding this comment.
I: This template change will be handled by a baton migration in my ticket (#351)
build-parent/pom.xml
Outdated
| @@ -67,6 +67,7 @@ | |||
| <version.awaitility>4.0.3</version.awaitility> | |||
| <version.plexus.util>3.5.1</version.plexus.util> | |||
| <version.jackson.mapper.asl>1.9.3</version.jackson.mapper.asl> | |||
| <version.kafka.client>3.8.0</version.kafka.client> | |||
There was a problem hiding this comment.
Q: Do we need to also update the kafka chart version, or is the client version compatible?
There was a problem hiding this comment.
Carter was able to test wit 3.8 and it is compatible. However I noticed data-access module doesnt need to use this version and exclude the quarkus version any more. So will remove it here and remove the exclusion from the quarkus dependency
There was a problem hiding this comment.
Thinking we should add something to the release notes about how that exclusion is no longer necessary
There was a problem hiding this comment.
Added a blurb in the release notes
cwoods-cpointe
force-pushed
the
415-upgrade-data-access-java17
branch
2 times, most recently
from
dd1d8b7 to
20f466c
Compare
Remove old kafka client dependency
cwoods-cpointe
force-pushed
the
415-upgrade-data-access-java17
branch
from
20f466c to
52c9545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update kafka client version in data access