Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add unit tests for pyproject.toml.vm Python version updates #379

Closed
8 tasks done
meliz19 opened this issue Sep 27, 2024 · 3 comments
Closed
8 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@meliz19
Copy link
Contributor

meliz19 commented Sep 27, 2024

Description

This is a follow on to #366. In that ticket, I updated the Python version in the pyproject.toml.vm files. The purpose of this ticket is to write unit tests to verify the Python version updates in all of the pyproject.toml.vm files.

DOD

  • Write unit tests for the following files to verify the Python version updates
  • foundation/foundation-mda/src/main/resources/templates/data-delivery-data-records/combined.pyproject.toml.vm
  • foundation/foundation-mda/src/main/resources/templates/data-delivery-data-records/separate.core.pyproject.toml.vm
  • foundation/foundation-mda/src/main/resources/templates/data-delivery-data-records/separate.spark.pyproject.toml.vm
  • foundation/foundation-mda/src/main/resources/templates/data-delivery-pyspark/pyproject.toml.vm
  • foundation/foundation-mda/src/main/resources/templates/general-mlflow/pyproject.toml.vm
  • foundation/foundation-mda/src/main/resources/templates/inference/pyproject.toml.vm
  • foundation/foundation-mda/src/main/resources/templates/sagemaker-training/pyproject.toml.vm

Test Strategy/Script

Test 1: OTS

  • From the root project directory, run the following command. Verify it builds successfully.
cd foundation/foundation-mda && ~/aissemble/mvnw clean install && cd -

Test 2

  • Verify the unit tests passed in the CI build

References/Additional Context

None

@meliz19 meliz19 added the enhancement New feature or request label Sep 27, 2024
@meliz19 meliz19 self-assigned this Sep 27, 2024
@meliz19 meliz19 changed the title Feature: Add unit tests for pyproject.toml & pyproject.toml.vm Python version updates Feature: Add unit tests for pyproject.toml.vm Python version updates Sep 27, 2024
@meliz19
Copy link
Contributor Author

meliz19 commented Sep 27, 2024

Completed DoD with @d-ryan-ashcraft

meliz19 added a commit that referenced this issue Oct 2, 2024
@meliz19
Copy link
Contributor Author

meliz19 commented Oct 2, 2024

Completed OTS with @cwoods-cpointe @habibimoiz

meliz19 added a commit that referenced this issue Oct 3, 2024
meliz19 added a commit that referenced this issue Oct 4, 2024
meliz19 added a commit that referenced this issue Oct 4, 2024
meliz19 added a commit that referenced this issue Oct 4, 2024
…ct-velocity-templates

#379 Add unit tests to check pyproject.toml velocity template Python …
@chang-annie
Copy link
Contributor

test steps are passing! CI build succeeded and all the unit tests passed.

meliz19 added a commit that referenced this issue Oct 11, 2024
…agemaker-poetry-lock-slowness

#379 Investigate slow nightly CI build time & improve it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants