#379 Add unit tests to check pyproject.toml velocity template Python … #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilkins-csi
reviewed
Oct 2, 2024
| StepElement pipelineStep = createPipelineStep(pipelineStepName, pipelineStepType); | ||
| pipeline.addStep(pipelineStep); | ||
| } catch (Exception e) { | ||
| System.err.println("Exception: " + e.getMessage()); |
There was a problem hiding this comment.
S: Something like logger.error("Failed to add new step to test pipeline", e) will provide more useful output. It will print both the exception message and the full stack trace, while also giving info about what we were attempting when the error occurred.
There was a problem hiding this comment.
Great point. I'll make the update. Thank you!
meliz19
force-pushed
the
379-add-unit-tests-for-pyproject-velocity-templates
branch
from
f40b76d to
ee5fdee
Compare
carter-cundiff
approved these changes
Oct 3, 2024
meliz19
force-pushed
the
379-add-unit-tests-for-pyproject-velocity-templates
branch
from
ee5fdee to
9b86f60
Compare
…version updates
meliz19
force-pushed
the
379-add-unit-tests-for-pyproject-velocity-templates
branch
from
9b86f60 to
c3b798b
Compare
meliz19
deleted the
379-add-unit-tests-for-pyproject-velocity-templates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…version updates