Consistent casing for parameters #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/develop: Redirect file-like object, don't use isinstance Update JSON model with latest versions Allow for ETS to SkipTest for HTTP status of 429 Fixed failing tests from pagination changes. Updated pagination tests to add expressions. Pagination changes from feedback. Updated pagination for jmespath ``result_key``s. Altered pagination to use ``more_results``. Add more special cases for case conversions Fix case conversion issue with SwapEnvironmentCNAMEs fix json -> xml request payload conversion Bumping version to 0.33.0 Update route53 to the latest model Never catch a bare except clause
| import re | ||
|
|
||
|
|
||
| def pythonic(var_name): |
There was a problem hiding this comment.
You should be able to use botocore.xform_name for this.
|
Thanks very much for fixing this. |
jamesls
added a commit
to jamesls/botocore
that referenced
this pull request
Apr 1, 2014
This is a regression introduced from boto#240 The fix here is to not translate names if they already appear to be translated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for consistent, camel cased parameters (See #217).
I chose to implement camel cased names to be consistent with the AWS APIs, and because the
alternative is to recursively check and convert snake case to camel case names - which could prove troublesome.
The following, which did not work before, works now: