Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in xform_name for already transformed names #268

Merged
merged 1 commit into from
Apr 2, 2014
Merged

Fix bug in xform_name for already transformed names #268

merged 1 commit into from
Apr 2, 2014

Conversation

jamesls
Copy link
Member

@jamesls jamesls commented Apr 1, 2014

This is a regression introduced from #240

When you try to create a trail you'll get an error:

Unknown parameter 's_3_bucket_name' for operation Operation:CreateTrail.  Must b
e one of: name, s3_bucket_name, s3_key_prefix, sns_topic_name, include_global_se
rvice_events, trail

The issue is that we xform s3_bucket_name again and get s_3_bucket_name. The fix here is to not translate names if they already appear to be translated.

@jamesls
Fix bug in xform_name for already transformed names
f8e6391 
This is a regression introduced from boto#240

The fix here is to not translate names if they already appear
to be translated.
@danielgtaylor
Copy link
Member

LGTM thanks for the fix. 🚢-it!

@danielgtaylor
Copy link
Member

The Travis build failed way early so I restarted it. Hopefully this time it works.

@danielgtaylor
Copy link
Member

Build passed this time. 🚢-it!

@jamesls jamesls merged commit f8e6391 into boto:develop Apr 2, 2014
@jamesls jamesls deleted the cloudtrail-args branch June 23, 2014 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesls @danielgtaylor