Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for context params in service models #2740

Merged
merged 5 commits into from
Sep 16, 2022

Conversation

jonemo
Copy link
Contributor

@jonemo jonemo commented Aug 18, 2022

Service model files (/botocore/data/*/*/service-2.json) will soon contain information about three types of "context params":

  1. static context parameters, optional for each operation
  2. (dynamic) context parameters, optional for each operation
  3. client context parameters, optional for each service

This PR adds properties for accessing context parameters information in the ServiceModel class.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2022

Codecov Report

Merging #2740 (43f620f) into develop (1504eb4) will decrease coverage by 0.01%.
The diff coverage is 95.83%.

@@             Coverage Diff             @@
##           develop    #2740      +/-   ##
===========================================
- Coverage    95.25%   95.24%   -0.02%     
===========================================
  Files           60       62       +2     
  Lines        12278    12869     +591     
===========================================
+ Hits         11696    12257     +561     
- Misses         582      612      +30     
Impacted Files Coverage Δ
botocore/model.py 98.14% <95.83%> (-0.14%) ⬇️
botocore/signers.py 95.98% <0.00%> (-2.18%) ⬇️
botocore/configloader.py 97.91% <0.00%> (-2.09%) ⬇️
botocore/utils.py 93.59% <0.00%> (-0.02%) ⬇️
botocore/args.py 100.00% <0.00%> (ø)
botocore/tokens.py 86.41% <0.00%> (ø)
botocore/endpoint_provider.py 99.66% <0.00%> (ø)
botocore/credentials.py 98.65% <0.00%> (+<0.01%) ⬆️
botocore/exceptions.py 99.55% <0.00%> (+0.01%) ⬆️
botocore/client.py 98.74% <0.00%> (+0.01%) ⬆️
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

botocore/model.py Outdated Show resolved Hide resolved
Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jonemo jonemo merged commit d075423 into boto:develop Sep 16, 2022
@jonemo jonemo deleted the context-params branch September 16, 2022 20:27
aws-sdk-python-automation added a commit that referenced this pull request Sep 19, 2022
* release-1.27.76:
  Bumping version to 1.27.76
  Update to latest endpoints
  Update to latest models
  Endpoint resolution v2: builtin parameter values (#2759)
  Support for context params in service models (#2740)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants