Support client context params for s3control #2797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 93.57% // Head: 93.57% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2797 +/- ##
========================================
Coverage 93.57% 93.57%
========================================
Files 63 63
Lines 13300 13302 +2
========================================
+ Hits 12445 12447 +2
Misses 855 855
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nateprewitt
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #2740 introduced support for context params into Botocore. #2785 introduced a new way of resolving endpoints that utilizes context parameters.
There are three types of context params: Static, dynamic, and client context params. Botocore currently intends to support client context params only for the S3 services. The code in #2785 limits the use of client context params to
s3only. This PR expands this to additionally includes3control.This PR also introduces functional test coverage that uses minimal fake models and rulesets to assert that all three types of context param are passed into the endpoint provider when expected, and not otherwise.