build: use twoliter make #3342
Merged
build: use twoliter make #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Aug 16, 2023
|
The command has changed from |
|
Simplify |
|
Cleanup and twoliter now installs to a tempdir so we don't need an ignored directory. |
webern
force-pushed
the
twoliter-exec
branch
2 times, most recently
from
fe96dfc
to
680533e
Compare
|
Uses the published version of The Twoliter.toml file isn't doing much right now, I'm thinking about what to do here. This push isn't super helpful. |
|
In order support out-of-tree builds (see bottlerocket-os#2669 and https://github.com/bottlerocket-os/twoliter), we need to move the build system to the Twoliter repository. This commit starts this process by moving the Makefile.toml logic to Twoliter and using Twoliter as a facade over the build system.
|
Rebase over develop. This change now needs to be applied in the Twoliter git repo https://github.com/bottlerocket-os/bottlerocket/pull/2757/files#diff-0f47e53927f2a76fca4bf29143c158748d4969cceac86d63c48c9f360a5a8656 I created an issue for this. |
stmcginnis
approved these changes
Aug 18, 2023
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
twoliter makecommand in the Twoliter repository and add a tagIssue number:
Related to #2669
Description of changes:
In order support out-of-tree builds (see #2669 and https://github.com/bottlerocket-os/twoliter), we need to move the build system to the Twoliter repository. This commit starts this process by moving the Makefile.toml logic to Twoliter and using Twoliter as a facade over the build system.
Testing done:
cargo make buildcargo make amiTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.