makefile: fix positional arguments for testsys #3379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testsys was broken because Twoliter was intercepting the -f in this command: cargo make test -f /foo This is because Clap didn't work the way we thought it did. This fixes the issue.
rpkelly
approved these changes
Aug 30, 2023
ecpullen
approved these changes
Aug 30, 2023
|
This build error appears unrelated to twoliter, assuming the other variant/arches pass: |
|
Similar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Fixes a problem with #3342
N/A
Description of changes:
Testsys was broken because Twoliter was intercepting the -f in this command:
cargo make test -f /foo
This is because Clap didn't work the way we thought it did. This fixes the issue.
Testing done:
We checked all of the commands that use splatting of cargo make arguments (basically all of the the testsys makefile targets) to make sure testsys was being invoked correctly.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.