Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.0 release #5

Merged
merged 24 commits into from
May 21, 2024
Merged

1.2.0 release #5

merged 24 commits into from
May 21, 2024

Conversation

bourumir-wyngs
Copy link
Owner

This release is mostly about URDF parameter parsing.

@bourumir-wyngs bourumir-wyngs changed the title 1.2.1 release 1.2.0 release May 21, 2024
@gavanderhoorn
Copy link
Contributor

Nice feature.

Can you say anything about whether this depends on conventions in the URDF/XACRO, or is it mathematically robust against different approaches to modelling a particular robot's kinematic structure?

@bourumir-wyngs bourumir-wyngs merged commit d61fd57 into main May 21, 2024
1 check passed
@bourumir-wyngs
Copy link
Owner Author

For all robots we tested, the joint offsets in URDF follow the clear pattern matching OPW parameters. There are ways to obfuscate this with fixed joints in between potentially representing offsets, or by describing the whole robot as rotated by unusual angle (say 45 degrees) but I have never seen such an URDF. It is not obvious how much it is a problem.

@gavanderhoorn
Copy link
Contributor

gavanderhoorn commented May 22, 2024

ah, ok. Thanks.

if you've mostly looked at robots modelled by people in ROS-Industrial repositories I fear conventions made this work well.

We have/had a rather strict approach to modelling kinematic chains, which (by coincidence) aligned well with how the OPW paper does it.

(I've been one of the reviewers for many of those models)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants