PHP 8.1: properly fix the requirement checker

[andypost]

When box packaging it prefixes attribute class with HumbugBox release version

This was broken after efdf63b see

box/.requirement-checker/src/RequirementCollection.php

Line 8 in efdf63b

use HumbugBox3140\ReturnTypeWillChange;

PS: follow-up to #578

[andypost]

I'm getting following error after packaging with 3.14.0 (as there's no .phar in 3.14.1 release assets)

PHP Deprecated:  Return type of HumbugBox3130\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/bin/drush/.box/src/RequirementCollection.php on line 12

Deprecated: Return type of HumbugBox3130\KevinGH\RequirementChecker\RequirementCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/bin/drush/.box/src/RequirementCollection.php on line 12
PHP Deprecated:  Return type of HumbugBox3130\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/bin/drush/.box/src/RequirementCollection.php on line 16

Deprecated: Return type of HumbugBox3130\KevinGH\RequirementChecker\RequirementCollection::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in phar:///usr/bin/drush/.box/src/RequirementCollection.php on line 16

[jrfnl]

This sounds like something which should be fixed in PHP_Scoper, not here.

[andypost]

@jrfnl please point which issue to follow? I guess humbug/php-scoper#530

OTOH why the attribut should be in "use"? I find it much more predictable to grep it via #[\ReturnTypeWillChange] as PHP mentions it in error message

[jrfnl]

@jrfnl please point which issue to follow? I guess humbug/php-scoper#530

Issue humbug/php-scoper#539 is specifically about this issue.

OTOH why the attribut should be in "use"?
I find it much more predictable to grep it via #[\ReturnTypeWillChange] as PHP mentions it in error message

Well, ReturnTypeWillChange is a class and most projects have (code-style/clean code) rules in place to use import use statements for all classes.
Every project can make their own decisions on how to handle it, of course.

Regarding the error message, yeah, I'm happy that that was changed (multiple times) after the original PR for this RFC went into PHP to include the attribute and the \.
The original error message from PHP was very unhelpful.

[andypost]

Thank you for explanation! Closing it in favour of php-scoper