Replace gometalinter by golangci-lint #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on so many external binaries (of unspecified version) installed dynamically makes gometalinter very brittle: each CI run may come up with linters variations. gometalinter itself is not very stable; newer gometalinter suddenly abandoning megacheck support was the last straw that breaks the camel's back. Icing on the cake, golangci-lint is much faster.
bpineau
force-pushed
the
adopt-golangci-lint
branch
from
9709722 to
e96cbd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on so many external binaries (of unspecified version)
installed dynamically makes gometalinter very brittle: each CI
run may come up with linters variations.
gometalinter itself is not very stable; newer gometalinter
suddenly abandoning megacheck support was the last straw that
breaks the camel's back.
Icing on the cake, golangci-lint is much faster.