fix: display multi-instance configuration in properties panel #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
requested review from
a team,
philippfromme and
marstamm
and removed request for
a team
barmac
commented
Oct 20, 2023
| @@ -48,7 +53,7 @@ export default class ElementTemplatesPropertiesProvider { | |||
| }; | |||
|
|
|||
| // (1) Add templates group | |||
| addGroupsAfter('documentation', groups, [ templatesGroup ]); | |||
| addGroupsAfter(ALWAYS_DISPLAYED_GROUPS, groups, [ templatesGroup ]); | |||
There was a problem hiding this comment.
As a side effect, the template group is displayed above "Documentation". There were no tests about this, so I assumed the value was included by accident. Also, in the old properties panel "Catalog" was displayed above "Documentation".
There was a problem hiding this comment.
Documentation is gone as soon as one applies a template.
nikku
added a commit
that referenced
this pull request
Feb 22, 2024
nikku
added a commit
that referenced
this pull request
Feb 22, 2024
nikku
added a commit
that referenced
this pull request
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#3396