Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

As a User, I cannot use multi-instance on a task with a template applied #3396

Closed
CatalinaMoisuc opened this issue Jan 12, 2023 · 8 comments · Fixed by #3944
Closed

As a User, I cannot use multi-instance on a task with a template applied #3396

CatalinaMoisuc opened this issue Jan 12, 2023 · 8 comments · Fixed by #3944
Assignees
@barmac
Labels
bug Something isn't working channel:customer element templates
Milestone
M70

Comments

@CatalinaMoisuc
Copy link
Member

CatalinaMoisuc commented Jan 12, 2023 •
edited by nikku
Loading

This supports https://github.com/camunda/product-hub/issues/1851.

Describe the bug

As a User, I cannot model in Camunda Modeler a task that has a template applied to it and is also multi instance.

Steps to reproduce

  1. model a task
  2. apply any template to it
  3. make it multi instance
  4. see properties panel not displaying the section that I need to configure the multi instance i.e. Input Collection

See recording:

Screen.Recording.2023-01-12.at.15.53.11.mov

Expected behavior

When I apply a template to a task and then I make the task multi instance, the respective Properties Panel section should appear.

Environment

  • OS: any
  • Camunda Modeler Version: 5.7
  • Execution Platform: Camunda 8
  • Installed plug-ins: irrelevant

Additional context

No response

Depends on bpmn-io/bpmn-js-properties-panel#907
@CatalinaMoisuc CatalinaMoisuc added the bug Something isn't working label Jan 12, 2023
@nikku
Copy link
Member

nikku commented Jan 12, 2023

We decided to not showcase stock properties panel sections except for "General" when a template is applied. This may be an exception to the rule.

Alternatively we'd need to allow users to conditionally template all multi-instance related properties.

Moving to backlog for the moment. Thanks for reporting.

@nikku nikku added the backlog Queued in backlog label Jan 12, 2023
@CatalinaMoisuc
Copy link
Member Author

cc @NPDeehan who reported this in Slack.

@CatalinaMoisuc
Copy link
Member Author

fyi, this issue was also reported yesterday by @Belike internally via a customer.

@nikku nikku mentioned this issue Apr 25, 2023
Closed
@Oleksiivanov Oleksiivanov mentioned this issue Jun 9, 2023
Closed
@nikku
Copy link
Member

nikku commented Jun 9, 2023

Also reported via camunda/connectors#470 and bpmn-io/bpmn-js-properties-panel#907.

@barmac
Copy link
Collaborator

barmac commented Jun 12, 2023

Let's discuss it in the next iteration planning. Moving to ready. We can still move it to backlog.

@barmac barmac added ready Ready to be worked on and removed backlog Queued in backlog labels Jun 12, 2023
@nikku
Copy link
Member

nikku commented Jun 27, 2023

FYI @christian-konrad. This is a medium sized issue and we did not prioritize it.

@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Jun 27, 2023
@nikku
Copy link
Member

nikku commented Jul 11, 2023

An alternative raised by @christian-konrad is to restore the properties-panel@0 / Modeler@4 behavior to allow additional stock configuration to be shown along with templated properties through entriesVisible.

For C7 there exists a customer request for that.

@nikku nikku added this to the M70 milestone Oct 17, 2023
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Oct 17, 2023
barmac added a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Oct 20, 2023
@barmac
fix: display multi-instance configuration in properties panel
ca7330c 
Related to camunda/camunda-modeler#3396
@barmac barmac mentioned this issue Oct 20, 2023
Merged
@barmac
Copy link
Collaborator

barmac commented Oct 20, 2023

This will be fixed upstream via bpmn-io/bpmn-js-element-templates#27

fake-join bot pushed a commit to bpmn-io/bpmn-js-element-templates that referenced this issue Oct 23, 2023
@barmac @fake-join
fix: display multi-instance configuration in properties panel
774b9cb 
Related to camunda/camunda-modeler#3396
@barmac barmac added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Oct 23, 2023
barmac added a commit that referenced this issue Oct 24, 2023
@barmac
fix: display multi-instance configuration in properties panel
6afc80b 
Closes #3396

deps: update to `camunda-bpmn-js@3.6.1`

deps: update to `bpmn-js-element-templates@1.6.1`
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed fixed upstream Requires integration of upstream change labels Oct 24, 2023
@barmac barmac mentioned this issue Oct 24, 2023
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 24, 2023
marstamm pushed a commit that referenced this issue Oct 24, 2023
@barmac @marstamm
fix: display multi-instance configuration in properties panel
81d613c 
Closes #3396

deps: update to `camunda-bpmn-js@3.6.1`

deps: update to `bpmn-js-element-templates@1.6.1`
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working channel:customer element templates
Projects
None yet
Milestone
M70
Development

Successfully merging a pull request may close this issue.

fix: display multi-instance configuration in properties panel camunda/camunda-modeler
3 participants
@nikku @CatalinaMoisuc @barmac