Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rename task listener event types #1098

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: rename task listener event types #1098

merged 2 commits into from
Dec 13, 2024

Conversation

barmac
Copy link
Member

@barmac barmac commented Dec 12, 2024

Proposed Changes

Screen.Recording.2024-12-12.at.18.31.25.mov

This implements the event types change. The legacy name is displayed in a label and can be changed in a one-way manner.
We could consider displaying the unknown name in the select too, but this means it will still appear in the options to select.

Related to camunda/camunda-modeler#4748

Requires camunda/camunda-bpmn-js-behaviors#92 to be released and integrated.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Dec 12, 2024
@barmac barmac marked this pull request as draft December 12, 2024 17:36
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Dec 12, 2024
@barmac barmac marked this pull request as ready for review December 13, 2024 13:41
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Dec 13, 2024
@barmac barmac merged commit 9a6aa44 into main Dec 13, 2024
10 checks passed
@barmac barmac deleted the new-event-types branch December 13, 2024 13:41
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants