feat: relax zeebe:TaskListeners cleanup based on event types
#92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barmac
force-pushed
the
relax-event-types-cleanup
branch
from
40b7020 to
b13f47e
Compare
4 tasks
barmac
requested review from
a team,
philippfromme and
abdul99ahad
and removed request for
a team
nikku
reviewed
Dec 13, 2024
| @@ -74,7 +73,6 @@ function withoutDisallowedListeners(element, listeners) { | |||
| return listeners.filter(listener => { | |||
| if ( | |||
| !is(element, 'bpmn:UserTask') || | |||
| !ALLOWED_EVENT_TYPES.includes(listener.eventType) || | |||
There was a problem hiding this comment.
I think this is generally a better behavior now. We should not cleanup everything, rigidly, always, and this is such a case.
nikku
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#4748