Add Markers to Input fields expecting FEEL expressions #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
force-pushed
the
599-feel-icons
branch
2 times, most recently
from
8d87c73
to
7304cb0
Compare
marstamm
force-pushed
the
599-feel-icons
branch
from
7304cb0
to
ad87e5d
Compare
|
|
marstamm
force-pushed
the
599-feel-icons
branch
2 times, most recently
from
0e71aa9
to
04b565f
Compare
marstamm
changed the title
bpmn-io-tasks
bot
added
needs review
marstamm
requested review from
a team,
Skaiir and
smbea
and removed request for
a team
MaxTru
reviewed
Mar 15, 2022
marstamm
force-pushed
the
599-feel-icons
branch
from
04b565f
to
cfdba94
Compare
MaxTru
requested changes
Mar 16, 2022
There was a problem hiding this comment.
The completionCondition must be FEEL isn't it? See https://docs.camunda.io/docs/components/modeler/bpmn/multi-instance/#completion-condition
Am I missing something?
|
According to the validation config, it is optional 🤔 |
|
Let's go with what the Documentation says, to avoid confusing the user |
MaxTru
reviewed
Mar 16, 2022
MaxTru
requested changes
Mar 16, 2022
There was a problem hiding this comment.
Really cool feature! Works also really nice.
Just minor things...
- Could we please include an example of feel element template config into https://github.com/bpmn-io/bpmn-js-properties-panel/blob/master/test/spec/provider/cloud-element-templates/fixtures/complex.bpmn so that this can easier be tested by running
start:cloud-templates?
- `@bpmn-io/properties-panel@0.12.0` - `element-templates-validator@0.6.0`
marstamm
force-pushed
the
599-feel-icons
branch
from
e98a26d
to
662cac3
Compare
|
I added the suggestions and cleaned up the commit history a bit. Ready for review again |
marstamm
added
needs review
MaxTru
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FEEL icons to all input fields that accept an expression. Note that the implementation was done in bpmn-io/properties-panel#138 and this PR just adds the required props to the input fields.
It is also possible to define a custom property to require FEEL in the configuration (related: camunda/element-templates-json-schema#46)