-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add feel
property
#46
Conversation
@pinussilvestrus, I tried out to implement the rule "Feel is only valid for type String and Text" and actually got it to work 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good basically. If you want to, I could do another try on Monday whether we can make the rule a bit more readable. 👍
packages/element-templates-json-schema-shared/src/defs/base-properties.json
Outdated
Show resolved
Hide resolved
packages/element-templates-json-schema-shared/src/defs/base-properties.json
Outdated
Show resolved
Hide resolved
packages/element-templates-json-schema-shared/src/defs/base-properties.json
Outdated
Show resolved
Hide resolved
packages/element-templates-json-schema-shared/src/defs/base-properties.json
Outdated
Show resolved
Hide resolved
Thank you for the feedback! I will look into this on monday and come back to you if it does not work |
Maybe something like this (using a similar pattern as for {
"if": {
"properties": {
"feel": {
"not": {
"const": null
}
}
},
"required": [
"feel"
]
},
"then": {
"properties": {
"type": {
"enum": [
"String",
"Text"
],
"errorMessage": "feel is only valid for \"String\" and \"Text\" type"
}
},
"required": [
"type"
]
}
} |
e6f5cf0
to
20a6e71
Compare
Thank you for the feedback! I changed the PR accordingly. Ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@marstamm fyi: I squashed the two commits together on |
Thank you for the heads up. #45 changed the examples and titles of everything, so we will release patches for shared and camunda schema anyway 😄 |
related to bpmn-io/bpmn-js-properties-panel#606