Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-element context pad 'delete' action #1525

Merged
merged 1 commit into from
May 25, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Nov 5, 2021

Adds BPMN specific multi-element context pad actions:

  • Bulk delete
  • Bulk coloring
  • Alignment and distribution

capture 8bd4so_optimized


Related to bpmn-io/diagram-js#278

Depends on bpmn-io/diagram-js#587

@smbea
Copy link
Contributor

smbea commented May 18, 2022

Like I did for the diagram-js PR, I will bring this up to date and push the updated version

@smbea smbea force-pushed the multi-element-context-pad branch from 21a7f43 to f1da31f Compare May 18, 2022 09:41
@smbea smbea linked an issue May 19, 2022 that may be closed by this pull request
2 tasks
@nikku nikku added in progress Currently worked on and removed backlog Queued in backlog labels May 24, 2022
@nikku nikku self-assigned this May 24, 2022
@nikku nikku force-pushed the multi-element-context-pad branch from f1da31f to 435867b Compare May 24, 2022 17:33
@nikku nikku requested review from a team, philippfromme, marstamm and smbea and removed request for a team May 24, 2022 17:34
@nikku nikku force-pushed the multi-element-context-pad branch from 435867b to 097d55c Compare May 24, 2022 17:40
@nikku nikku marked this pull request as ready for review May 24, 2022 17:41
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 24, 2022
@nikku
Copy link
Member Author

nikku commented May 24, 2022

Updated to provide the delete pad action on top of latest diagram-js improvements.

@nikku nikku force-pushed the multi-element-context-pad branch from 097d55c to 98ee33f Compare May 25, 2022 06:10
Copy link
Contributor

@smbea smbea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me and works great. Happy to have this in bpmn-js 🤗

@nikku nikku merged commit 3d193b2 into develop May 25, 2022
@nikku nikku deleted the multi-element-context-pad branch May 25, 2022 07:03
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 25, 2022
@smbea smbea changed the title Add multi-element context pad actions Add multi-element context pad 'delete' action Jun 7, 2022
@smbea smbea mentioned this pull request Jun 7, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants