-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi-element context pad 'delete' action #1525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
force-pushed
the
multi-element-context-pad
branch
2 times, most recently
from
November 5, 2021 17:12
2a9d061
to
21a7f43
Compare
10 tasks
nikku
added
backlog
Queued in backlog
and removed
in progress
Currently worked on
labels
Nov 9, 2021
2 tasks
Like I did for the diagram-js PR, I will bring this up to date and push the updated version |
smbea
force-pushed
the
multi-element-context-pad
branch
from
May 18, 2022 09:41
21a7f43
to
f1da31f
Compare
2 tasks
2 tasks
nikku
added
in progress
Currently worked on
and removed
backlog
Queued in backlog
labels
May 24, 2022
nikku
force-pushed
the
multi-element-context-pad
branch
from
May 24, 2022 17:33
f1da31f
to
435867b
Compare
nikku
requested review from
a team,
philippfromme,
marstamm and
smbea
and removed request for
a team
May 24, 2022 17:34
nikku
force-pushed
the
multi-element-context-pad
branch
from
May 24, 2022 17:40
435867b
to
097d55c
Compare
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
May 24, 2022
Updated to provide the delete pad action on top of latest diagram-js improvements. |
nikku
force-pushed
the
multi-element-context-pad
branch
from
May 25, 2022 06:10
097d55c
to
98ee33f
Compare
smbea
approved these changes
May 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and works great. Happy to have this in bpmn-js 🤗
smbea
changed the title
Add multi-element context pad actions
Add multi-element context pad 'delete' action
Jun 7, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds BPMN specific multi-element context pad actions:
Bulk coloringAlignment and distributionRelated to bpmn-io/diagram-js#278
Depends on bpmn-io/diagram-js#587