Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to provide context pads for multiple elements #587

Merged
merged 5 commits into from
May 19, 2022

Conversation

nikku
Copy link
Member

@nikku nikku commented Nov 5, 2021

Adds the ability to create a context pad around more than one element:

  • dedicated selection box surrounds all selected elements
    • implement
    • test
  • a new context pad provider APIs allows provider to provide pads for more than one element (c.f. Add multi-element context pad 'delete' action bpmn-js#1525)
    • implement
    • test
  • context pad is now single and multi-element aware. Target now generalized to djs.model.Base || djs.model.Base[] accordingly.
  • even out popup menu entries so that image only entries are possible (366b5c9).
  • fix selection not updating if selected elements changed (undo/redo)
  • test isOpen api

Capture of the thing in action for "delete" example (with reaction to undo/redo):

Screen.Recording.2022-05-18.at.12.34.00.mov

Delete can be tested by using bpmn-io/bpmn-js#1525 and linking this instance of diagram-js

Closes #278

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 5, 2021
@nikku nikku added backlog Queued in backlog and removed in progress Currently worked on labels Nov 9, 2021
@smbea
Copy link
Contributor

smbea commented May 17, 2022

I tested this with the updated diagram-js (on develop) and it works. Only requires a small change on the old getActivePlane function call. Will push the updated version and work from there.

It also works well with subprocess drilldown.

@smbea smbea self-assigned this May 17, 2022
@smbea smbea force-pushed the multi-element-context-pad branch 5 times, most recently from 6a0c551 to 4593890 Compare May 18, 2022 09:24
@smbea smbea force-pushed the multi-element-context-pad branch from 4593890 to 0047f1c Compare May 18, 2022 09:56
@smbea smbea marked this pull request as ready for review May 18, 2022 10:14
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed backlog Queued in backlog labels May 18, 2022
@nikku nikku requested review from a team, marstamm and barmac and removed request for a team May 18, 2022 10:37
@smbea smbea requested a review from philippfromme May 19, 2022 07:33
Copy link
Contributor

@marstamm marstamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Tested it and am looking forward to have it in bpmn-js 🚀

@fake-join fake-join bot merged commit 7065444 into develop May 19, 2022
@fake-join fake-join bot deleted the multi-element-context-pad branch May 19, 2022 08:32
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-element context pad
3 participants