Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearing Predefined Values Navigates #431

Closed
philippfromme opened this issue Nov 4, 2019 · 4 comments
Closed

Clearing Predefined Values Navigates #431

philippfromme opened this issue Nov 4, 2019 · 4 comments
Assignees
@barmac
Labels
bug Something isn't working
Milestone
M32

Comments

@philippfromme
Copy link
Contributor

dmn-js-anchor

Describe the Bug

Clicking the <a> tag to clear predefined values navigates to #. This doesn't happen in the Camunda Modeler but it happens on demo.bpmn.io/dmn.

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open decision table
  2. Clear predefined values

Expected Behavior

No navigation.
@philippfromme philippfromme added the bug Something isn't working label Nov 4, 2019
@barmac
Copy link
Member

barmac commented Nov 4, 2019

I'm wondering why it is a link in the first place...

@philippfromme
Copy link
Contributor Author

I'm wondering why it is a link in the first place...

Good question.

@barmac
Copy link
Member

barmac commented Nov 4, 2019 •
edited
Loading

Also, this is not the only place where the <a href="#" /> is used as a button. This happens in the InputEditor too.

@barmac barmac self-assigned this Nov 4, 2019
barmac added a commit that referenced this issue Nov 4, 2019
@barmac
fix(decision-table): use button instead of link in hints
9481606 
Closes #431
@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 4, 2019
@barmac barmac mentioned this issue Nov 4, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 4, 2019
barmac added a commit that referenced this issue Nov 4, 2019
@barmac
fix(decision-table): use button instead of link in hints
2e73132 
Closes #431
barmac added a commit that referenced this issue Nov 4, 2019
@barmac
fix(decision-table): use button instead of link in hints
c5eed3e 
Closes #431
fake-join bot pushed a commit that referenced this issue Nov 5, 2019
@barmac @fake-join
fix(decision-table): use button instead of link in hints
9578f61 
Closes #431
@barmac
Copy link
Member

barmac commented Nov 5, 2019

Closed via #432

@barmac barmac closed this as completed Nov 5, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 5, 2019
@nikku nikku added this to the M32 milestone Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
M32
Development

No branches or pull requests
3 participants
@nikku @philippfromme @barmac