Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use button for buttons in hints #432

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Use button for buttons in hints #432

merged 2 commits into from
Nov 5, 2019

Conversation

barmac
Copy link
Member

@barmac barmac commented Nov 4, 2019

Closes #431

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Nov 4, 2019
@philippfromme
Copy link
Contributor

Can you attach a screenshot?

@barmac
Copy link
Member Author

barmac commented Nov 4, 2019

Old:
Screenshot 2019-11-04 at 13 30 23
New:
Screenshot 2019-11-04 at 13 31 44

@barmac barmac force-pushed the 431-use-button-for-buttons-in-hints branch from 9481606 to 2e73132 Compare November 4, 2019 12:35
@barmac barmac force-pushed the 431-use-button-for-buttons-in-hints branch from 2e73132 to c5eed3e Compare November 4, 2019 12:42
@barmac
Copy link
Member Author

barmac commented Nov 4, 2019

Firefox:
Screenshot 2019-11-04 at 13 36 45

Safari:
Screenshot 2019-11-04 at 13 43 24

philippfromme
philippfromme approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@fake-join fake-join bot merged commit 9578f61 into master Nov 5, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 5, 2019
@fake-join fake-join bot deleted the 431-use-button-for-buttons-in-hints branch November 5, 2019 08:32
@barmac barmac mentioned this pull request Nov 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barmac @philippfromme