Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new column header design #499

Closed
6 tasks
pinussilvestrus opened this issue Apr 17, 2020 · 0 comments · Fixed by #511
Closed
6 tasks

Implement new column header design #499

pinussilvestrus opened this issue Apr 17, 2020 · 0 comments · Fixed by #511
Assignees
@barmac
Labels
Decision Table enhancement New feature or request

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Apr 17, 2020 •
edited
Loading

What should we do?

Implement the new design of input/output column headers

Cf. Demo

image

image

  • Every cell has a When/And/Then clause depending on its position
    • First Input Column: When
    • First Output Column: Then
    • n+2nd Input/Output column: And
  • The input/output label is vertically centered and left-aligned
  • The input/output label is a single line only
  • The input/output label has a maximum width
  • The input/output label got cropped when it exceeds the maximum width
  • The input/output type OR allowed values are displayed in the bottom right corner

Things we can consider:

  • Open current type editing modal when clicking on the bottom-right type label, as an intermediate step
  • Keep the drag and drop functionality to change column order as it is
  • Currently we show the expression if no label is filled. What shall we do if it is a multi-line script?

Why should we do it?

We can get rid of multiple cells for the headers

Child #494
This was referenced Apr 17, 2020
Closed
Closed
@barmac barmac added the ready Ready to be worked on label Apr 22, 2020 — with bpmn-io-tasks
@barmac barmac self-assigned this Apr 30, 2020
@barmac barmac added in progress Currently worked on and removed ready Ready to be worked on labels May 12, 2020
barmac added a commit that referenced this issue May 19, 2020
@barmac
feat(decision-table-head): rework decision table head
d0b08cb 
* Only one row for column labels.
* Input/output context menu extended with type ref.
* Moved "add column" button to the right edge of column group.
* Added input/output clauses.
* Moved drag'n'drop handle to top right corner.

Closes #498
Closes #499
@barmac barmac mentioned this issue May 19, 2020
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels May 19, 2020
barmac added a commit that referenced this issue May 20, 2020
@barmac
feat(decision-table-head): rework decision table head
587ca4c 
* Only one row for column labels.
* Input/output context menu extended with type ref.
* Moved "add column" button to the right edge of column group.
* Added input/output clauses.
* Moved drag'n'drop handle to top right corner.

Closes #498
Closes #499
@fake-join fake-join bot closed this as completed in #511 Jun 9, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 9, 2020
fake-join bot pushed a commit that referenced this issue Jun 9, 2020
@barmac @fake-join
feat(decision-table-head): rework decision table head
b0546f7 
* Only one row for column labels.
* Input/output context menu extended with type ref.
* Moved "add column" button to the right edge of column group.
* Added input/output clauses.
* Moved drag'n'drop handle to top right corner.

Closes #498
Closes #499
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
Decision Table enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rework decision table head bpmn-io/dmn-js
2 participants
@pinussilvestrus @barmac