Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to resize decision table columns #500

Closed
9 tasks done
pinussilvestrus opened this issue Apr 17, 2020 · 7 comments · Fixed by #530
Closed
9 tasks done

Add ability to resize decision table columns #500

pinussilvestrus opened this issue Apr 17, 2020 · 7 comments · Fixed by #530
Assignees
Labels
Decision Table enhancement New feature or request

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Apr 17, 2020

Is your feature request related to a problem? Please describe.

Currently, decision table headers can not be resized. Our new decision table layout should introduce that ability.

Describe the solution you'd like

Make input/output / (annotation) columns resizable (horizontally)

Kapture 2020-04-15 at 13 21 57

Things to consider:

Introducing with the new column header layout (cf. #499) labels will have a max-width and can be cropped. Resizing the column width should follow this guideline in cropping, but it should be possible to give columns a custom width. This can potentially be stored inside the XML as extension property since the DMN standard does not have something like this.

Describe alternatives you've considered

/

Additional context

Child of #494

Acceptance criteria

  • input/output columns can be resized and content is cropped
  • hit policy hints are moved to title property
  • logo is moved (visually) inside the decision properties
  • cells' content is wrapped
  • annotations column can be resized
  • table keeps correct layout on minimum width
  • clauses are not visible on header cell hover
  • drag'n'drop handle is moved to the left
  • column width is saved in the XML
@barmac barmac added the ready Ready to be worked on label Apr 22, 2020 — with bpmn-io-tasks
@barmac
Copy link
Member

barmac commented May 5, 2020

We want the width to be saved (extension properties will help).

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 19, 2020
@barmac
Copy link
Member

barmac commented Jun 19, 2020

Should the content of the entries be cropped like we do with the label? What should happen to the layout of the table when you start editing the rule?

I think it could behave in a similar way as input/output editing, i.e. the entry cell should "emerge" from the table so that it does not affect table layout.

@pinussilvestrus
Copy link
Contributor Author

So basically what we come up with in this thread, am I right? Would agree with it, makes a lot of sense

@barmac
Copy link
Member

barmac commented Jun 19, 2020

Correct.

@barmac
Copy link
Member

barmac commented Jun 22, 2020

Progress so far: I have a concept how to implement the visuals. The table row with decision name will have to be moved out from the HTML table, so that table-layout: fixed can handle column widths. Still, I don't intend yet to change the visuals. Then, content of the cells will be hidden in case of overflow.

@barmac
Copy link
Member

barmac commented Jul 1, 2020

I've added Acceptance criteria to track issue status.

barmac added a commit to bpmn-io/dmn-moddle that referenced this issue Jul 2, 2020
barmac added a commit to bpmn-io/dmn-moddle that referenced this issue Jul 2, 2020
New moddle package contains column width-related properties.
These are:
	* `dmn:DecisionTable#annotationsWidth`
	* `dmn:InputClause#width`
	* `dmn:OutputClause#width`
All of the new properties are of type `Integer` and are supposed
to translate to pixel values of column width.

Related to bpmn-io/dmn-js#500
@barmac
Copy link
Member

barmac commented Jul 2, 2020

So I think this is the last problem to fix:
image

@barmac barmac mentioned this issue Jul 2, 2020
7 tasks
philippfromme pushed a commit to bpmn-io/dmn-moddle that referenced this issue Jul 3, 2020
New moddle package contains column width-related properties.
These are:
	* `dmn:DecisionTable#annotationsWidth`
	* `dmn:InputClause#width`
	* `dmn:OutputClause#width`
All of the new properties are of type `Integer` and are supposed
to translate to pixel values of column width.

Related to bpmn-io/dmn-js#500
barmac added a commit that referenced this issue Jul 3, 2020
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 3, 2020
barmac added a commit that referenced this issue Jul 3, 2020
barmac added a commit that referenced this issue Jul 3, 2020
barmac added a commit that referenced this issue Jul 6, 2020
barmac added a commit that referenced this issue Jul 6, 2020
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Jul 6, 2020
barmac added a commit that referenced this issue Jul 6, 2020
@barmac barmac added needs review Review pending and removed in progress Currently worked on labels Jul 7, 2020 — with bpmn-io-tasks
barmac added a commit that referenced this issue Jul 7, 2020
barmac added a commit that referenced this issue Jul 7, 2020
barmac added a commit that referenced this issue Jul 8, 2020
barmac added a commit that referenced this issue Jul 9, 2020
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Decision Table enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants