Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing value attribute in process variables as tag list options breaks the tag list #303

Closed
christian-konrad opened this issue Aug 8, 2022 · 1 comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day

Comments

@christian-konrad
Copy link
Contributor

christian-konrad commented Aug 8, 2022

Describe the Bug

When I feed process variables as tag list options, I must specify a list of key-value pairs, where I must provide both a value and a label for each select option. If I miss a value, it breaks the tag list: the value is still offered as a choice, but if I select it, it won't appear in the list of tags, but adds a null value to the output.

Additionally, the hint in the properties panel does not help me to understand in which format I need to provide the select options.

Steps to Reproduce

Best to be done in the playground.

  1. Provide a list of maps that contains at least one select option entry that does not have a value attribute
  2. Assign this map to a tag list component as the "value" input (actually the options input, name is confusing here)
  3. Select the item in the tag list and check the output

Also see the video.

Bildschirmaufnahme.2022-08-08.um.14.41.06.mov

Expected Behavior

In addition to fix the faulty behavior itself, we should add a hint in the properties panel on how to configure it: #305

Environment

  • Host (Browser/Node version), if applicable: [e.g. MS Edge 18, Chrome 69, Node 10 LTS]
  • OS: [e.g. Windows 7]
  • Library version: [e.g. 2.0.0]
@christian-konrad christian-konrad added the bug Something isn't working label Aug 8, 2022
@pinussilvestrus pinussilvestrus added the spring cleaning Could be cleaned up one day label Aug 15, 2022
@pinussilvestrus pinussilvestrus added the backlog Queued in backlog label Aug 15, 2022 — with bpmn-io-tasks
@smbea smbea self-assigned this Aug 16, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Aug 18, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Aug 18, 2022
@smbea smbea added the in progress Currently worked on label Aug 19, 2022 — with bpmn-io-tasks
@smbea smbea removed the needs review Review pending label Aug 19, 2022
smbea added a commit that referenced this issue Aug 19, 2022
smbea added a commit that referenced this issue Aug 19, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending in progress Currently worked on and removed in progress Currently worked on needs review Review pending labels Aug 19, 2022
@smbea
Copy link
Contributor

smbea commented Aug 19, 2022

Bug fix: #315
Description improvement: #316

fake-join bot pushed a commit that referenced this issue Aug 19, 2022
@smbea smbea added backlog Queued in backlog and removed in progress Currently worked on labels Aug 22, 2022
@smbea smbea removed their assignment Aug 22, 2022
@Skaiir Skaiir closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working spring cleaning Could be cleaned up one day
Projects
None yet
Development

No branches or pull requests

4 participants