fix(viewer): filter out invalid dynamic taglist options #315
Conversation
bpmn-io-tasks
bot
added
in progress
bpmn-io-tasks
bot
added
needs review
smbea
requested review from
a team,
pinussilvestrus and
barmac
and removed request for
a team
smbea
force-pushed
the
303-fix-taglist-dynamic-values
branch
2 times, most recently
from
2b3621a
to
468581a
Compare
| const schema = '[{"label": "dollar", "value": "$"}]'; | ||
|
|
||
| const description = <div> | ||
| Define which input property to populate the values from. The property must follow this schema: <code>{schema}</code>. |
There was a problem hiding this comment.
Should we maybe add the description as mentioned in the issue (#305)? So having "The property must follow ..." as another paragraph and add some indentation to the code example.
There was a problem hiding this comment.
I couldn't find an existing example in the properties panel of us using multi-line code. I added it using the pre html tag, but would need to extend the code styles to work for this too, and this should be done in the properties panel styles, right? What do you think?
There was a problem hiding this comment.
I like this one much more 👍
Ideally, this should be done by the core (description) styles, yeah, to align it across our tools.
There was a problem hiding this comment.
We could also split this PR into two parts (bug fix, description updates) and, make progress with the bug fix faster + deliver the style + description updates in another PR.
There was a problem hiding this comment.
I will make this PR just for the fix, then add a draft PR with the styling changes (to be merged when this is added to the core)
There was a problem hiding this comment.
All done: follow up is #316 (already mentioned in the issue)
smbea
added
in progress
smbea
force-pushed
the
303-fix-taglist-dynamic-values
branch
from
468581a
to
3ca17b6
Compare
Related to #303
For the properties panel hint: #305 is for adding a more sophisticated solution, but for now we decided to improve the existing description: