-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEEL support for min, max, minLength and maxLength #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinussilvestrus
changed the base branch from
develop
to
653-labels-descriptions-others
May 25, 2023 12:35
pinussilvestrus
changed the base branch from
653-labels-descriptions-others
to
653-adorners-images
May 25, 2023 12:35
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 25, 2023 13:21
507bc88
to
c49b98b
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 26, 2023 07:14
c49b98b
to
564db9d
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 26, 2023 07:51
564db9d
to
7753dd7
Compare
pinussilvestrus
force-pushed
the
653-adorners-images
branch
from
May 26, 2023 07:52
4037c07
to
630e576
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 26, 2023 07:53
7753dd7
to
4d15bb2
Compare
6 tasks
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 26, 2023 12:40
4d15bb2
to
f538bd1
Compare
pinussilvestrus
force-pushed
the
653-adorners-images
branch
2 times, most recently
from
May 26, 2023 14:52
fa58000
to
f80bdb7
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 26, 2023 14:52
f538bd1
to
183e0c3
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 30, 2023 07:16
183e0c3
to
67f1a12
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
May 30, 2023 14:21
67f1a12
to
a9dea29
Compare
pinussilvestrus
force-pushed
the
653-adorners-images
branch
from
June 12, 2023 08:57
f80bdb7
to
1aafed2
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
June 12, 2023 08:58
a9dea29
to
9ead324
Compare
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
June 13, 2023 06:59
9ead324
to
56dba97
Compare
bpmn-io-tasks
bot
added
needs review
Review pending
and removed
in progress
Currently worked on
labels
Jun 13, 2023
pinussilvestrus
requested review from
vsgoulart,
Skaiir,
christian-konrad and
RomanKostka
June 13, 2023 07:01
This is ready for review now. 👍 |
vsgoulart
approved these changes
Jun 13, 2023
packages/form-js-editor/test/spec/features/properties-panel/groups/ValidationGroup.spec.js
Show resolved
Hide resolved
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
June 15, 2023 13:23
56dba97
to
335904e
Compare
@christian-konrad @RomanKostka are you able to review this before the Retreat? So we can close the last one before the break 🙂 |
RomanKostka
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
looks good to me :)
pinussilvestrus
force-pushed
the
653-min-max-feel
branch
from
June 16, 2023 12:14
335904e
to
df544e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #653
Adds FEEL support for
min
,max
,minLength
andmaxLength
validation.Demo: https://demo-653-min-max-feel--camunda-form-playground.netlify.app/