Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feel): add number feel entry #248

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented May 25, 2023

Related to bpmn-io/form-js#653

Adds an optional FEEL number field entry. This enabled us to create number properties with FEEL support (e.g. min, max, minLength, maxLength in form-js, bpmn-io/form-js#668).

@pinussilvestrus pinussilvestrus requested review from vsgoulart, Skaiir, a team, smbea and barmac and removed request for a team May 25, 2023 12:43
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 25, 2023
@pinussilvestrus
Copy link
Contributor Author

I created a demo in form-js for the 4 mentioned validation properties: https://demo-653-min-max-feel--camunda-form-playground.netlify.app/

@pinussilvestrus
Copy link
Contributor Author

I found out that decimal numbers are not working anymore in the optional FEEL number field. I'll investigate.

@nikku
Copy link
Member

nikku commented May 26, 2023

Thanks @pinussilvestrus. I looked into the demo you provided and found one glitch: Entering a . breaks the editor focus (moves the cursor):

capture CFvskP_optimized

Expected behavior:

  • character is disallowed or character is passed, but an error message (invalid format) is shown

@pinussilvestrus
Copy link
Contributor Author

@nikku I decided to simply re-using the existing NumberField so we have a consistent behavior between FEEL and non-FEEL number entries. I'm not sure what's the expected behavior, but it should work the same as before now (without jumping cursor).

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me now.

@pinussilvestrus pinussilvestrus merged commit 6fbd8c8 into main May 30, 2023
@pinussilvestrus pinussilvestrus deleted the feel-number-entry branch May 30, 2023 07:11
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants