Feat/force disable dave on stage channel #1259
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can Dave not be used for stage channels? If it can, I don't think this PR is a good idea |
stage channels are just voice channels. if Dave isn't supported by a voice chat it automatically downgrades... besides we have no choice, supporting Dave will become mandatory some point next year |
braindigitalis
requested changes
Oct 5, 2024
|
|
||
| if (enable_dave) { | ||
| /* Disable dave if we're connecting to stage channel */ | ||
| auto *c = find_channel(channel_id); |
There was a problem hiding this comment.
I don't think this is a good idea, there's nothing special about stage channels that needs Dave disabled it's just the Dave pr isn't finished.
regardless this assumes channel cache is enabled which isn't going to work if you disable cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Code change checklist