Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/force disable dave on stage channel #1259

Closed
wants to merge 1 commit into from
Closed

Feat/force disable dave on stage channel #1259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/dpp/discordclient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,15 @@ discord_client& discord_client::connect_voice(snowflake guild_id, snowflake chan
return *this;
}
}

if (enable_dave) {
/* Disable dave if we're connecting to stage channel */
auto *c = find_channel(channel_id);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a good idea, there's nothing special about stage channels that needs Dave disabled it's just the Dave pr isn't finished.

regardless this assumes channel cache is enabled which isn't going to work if you disable cache.

if (c != nullptr && c->is_stage_channel()) {
enable_dave = false;
}
}

connecting_voice_channels[guild_id] = std::make_unique<voiceconn>(this, channel_id, enable_dave);
/* Once sent, this expects two events (in any order) on the websocket:
* VOICE_SERVER_UPDATE and VOICE_STATUS_UPDATE
Expand Down
Loading