This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
Rewards panel can now mark websites as included and excluded #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
force-pushed
the
feature/panel_inc_exc
branch
from
4681961 to
c7e8f5d
Compare
jasonrsadler
force-pushed
the
feature/panel_inc_exc
branch
2 times, most recently
from
3953665 to
e915674
Compare
NejcZdovc
reviewed
Oct 16, 2018
jasonrsadler
force-pushed
the
feature/panel_inc_exc
branch
from
e915674 to
4c21c42
Compare
jasonrsadler
force-pushed
the
feature/panel_inc_exc
branch
3 times, most recently
from
1355648 to
d986635
Compare
jasonrsadler
changed the title
jasonrsadler
force-pushed
the
feature/panel_inc_exc
branch
from
d986635 to
0d05674
Compare
NejcZdovc
force-pushed
the
feature/panel_inc_exc
branch
from
0d05674 to
bd4e71e
Compare
18 tasks
NejcZdovc
force-pushed
the
feature/panel_inc_exc
branch
from
bd4e71e to
62b5c5c
Compare
jasonrsadler
force-pushed
the
feature/panel_inc_exc
branch
from
62b5c5c to
3e35b5e
Compare
jasonrsadler
force-pushed
the
feature/panel_inc_exc
branch
2 times, most recently
from
0283ec9 to
734f335
Compare
NejcZdovc
force-pushed
the
feature/panel_inc_exc
branch
3 times, most recently
from
2fbfc80 to
75e2e4b
Compare
Contribution process fixes Auto-excluded publishers now show properly in Rewards panel. Set auto-excluded sites to zero duration Setting auto-excluded publishers to auto-contribute category wip - Contribution process fixes wip - wip - include_switch cleaning up debug lines cleaning up debug lines Hooked exclude state to panel include toggle
NejcZdovc
force-pushed
the
feature/panel_inc_exc
branch
from
75e2e4b to
be1c958
Compare
NejcZdovc
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
will create follow up that will handle all cases in the panel brave/brave-browser#1797
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the toggle does not slide however, the database is updated with 1 (user excluded) and 2 (user included). Disabling a site and tabbing off then back on will show 'off' in slider.core implementation brave/brave-core#591