Publishers can now be included and excluded #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
changed the title
jasonrsadler
added
PR/Pending Review
and removed
PR/Pending Review
pr/work-in-progress
labels
|
needs a rebase |
|
Rebased. |
jasonrsadler
added
pr/work-in-progress
PR/Pending Review
and removed
PR/Pending Review
pr/work-in-progress
labels
jasonrsadler
changed the title
NejcZdovc
previously requested changes
Oct 18, 2018
There was a problem hiding this comment.
../../brave/components/brave_rewards/browser/rewards_service_impl.h:113:8: error: 'brave_rewards::RewardsServiceImpl::SetContributionAutoInclude' hides overloaded virtual function [-Werror,-Woverloaded-virtual]
void SetContributionAutoInclude(
^
../../brave/vendor/bat-native-ledger/include/bat/ledger/ledger_client.h:120:16: note: hidden overloaded virtual function 'ledger::LedgerClient::SetContributionAutoInclude' declared here: different number of parameters (3 vs 2)
virtual void SetContributionAutoInclude(
^
../../brave/components/brave_rewards/browser/rewards_service_factory.cc:47:11: error: allocating an object of abstract class type 'brave_rewards::RewardsServiceImpl'
new RewardsServiceImpl(Profile::FromBrowserContext(context)));
^
../../brave/vendor/bat-native-ledger/include/bat/ledger/ledger_client.h:120:16: note: unimplemented pure virtual method 'SetContributionAutoInclude' in 'RewardsServiceImpl'
virtual void SetContributionAutoInclude(
^
2 errors generated.
[14/350] CXX obj/content/browser/browser/browser_context.o^C
It's not building for me
|
brave-intl/bat-native-ledger#144 goes with it. |
wip - debugging wip - wip - wip - include_switch linting clean up debugging Brackets for reducer switch case clean up debug lines linting for CI
NejcZdovc
approved these changes
Oct 23, 2018
There was a problem hiding this comment.
will create follow up that will handle all cases in the panel brave/brave-browser#1797
NejcZdovc
added a commit
that referenced
this pull request
Oct 23, 2018
Publishers can now be included and excluded
NejcZdovc
added a commit
that referenced
this pull request
Oct 23, 2018
Publishers can now be included and excluded
NejcZdovc
added a commit
that referenced
this pull request
Oct 23, 2018
Publishers can now be included and excluded
NejcZdovc
added a commit
that referenced
this pull request
Oct 24, 2018
Publishers can now be included and excluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#1283
Ledger native brave-intl/bat-native-ledger#144
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Toggle switch currently does not slide and will be handled in future PR.(Based on native and script type mismatches)
Reviewer Checklist: