Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist some sites to not block autoplay by default #1089

Closed
bbondy opened this issue Sep 10, 2018 · 8 comments · Fixed by brave/brave-core#599
Closed

Whitelist some sites to not block autoplay by default #1089

bbondy opened this issue Sep 10, 2018 · 8 comments · Fixed by brave/brave-core#599

Comments

@bbondy bbondy added this to the Releasable builds 0.55.x milestone Sep 10, 2018
@alexwykoff
Copy link

@bbondy
Copy link
Member Author

bbondy commented Sep 10, 2018

Netflix & Youtube already in the list. primevideo.com I think is the correct link for prime video, added it.

@maikelmclauflin
Copy link

maikelmclauflin commented Sep 10, 2018

there's https://d.tube/

and depending on how far down this rabbit hole you want to go you could include sites like https://www.lynda.com/,

podcasts probably fall under this as well
https://soundcloud.com/

music
https://www.pandora.com

may be a good thing to poll on reddit

@alexwykoff
Copy link

@bbondy good ole markdown tripped me up. that was a minus on youtube due to parenthetical reasons 😸

https://www.spotify.com/us/ might be worth a check given @maikelmclauflin 's entry

@bsclifton
Copy link
Member

The user could be presented with two options in the UI:

  • no inclusion list (ask for everything; allow custom inclusions)
  • automatically add popular websites to inclusion list

The welcome page could potentially present this question as one of the steps (and we could default to popular websites included)

@bbondy
Copy link
Member Author

bbondy commented Sep 11, 2018

I think I prefer reasonable defaults and allow user to override over forcing the user into making some kind of decision on our timeline.

@cndouglas
Copy link
Contributor

Periscope: https://www.periscope.tv and https://www.pscp.tv

@srirambv
Copy link
Contributor

srirambv commented Oct 15, 2018

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

Except for Sound cloud( #1584) and D Tube(#1581)

Verified passed with

Brave 0.55.14 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants