Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoplay some sites in absence of explicit block rule #599

Merged
merged 4 commits into from
Oct 11, 2018
Merged

Autoplay some sites in absence of explicit block rule #599

merged 4 commits into from
Oct 11, 2018

Conversation

pilgrim-brave
Copy link
Contributor

Fixes brave/brave-browser#1089

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@pilgrim-brave pilgrim-brave requested review from bbondy and removed request for bbondy October 10, 2018 19:32
@bbondy bbondy changed the title Autoplay some sites in absence of explicit block rule WIP: Autoplay some sites in absence of explicit block rule Oct 11, 2018
@bbondy bbondy changed the title WIP: Autoplay some sites in absence of explicit block rule Autoplay some sites in absence of explicit block rule Oct 11, 2018
bbondy
bbondy approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bbondy bbondy merged commit b9bebf0 into brave:master Oct 11, 2018
bbondy added a commit that referenced this pull request Oct 11, 2018
@bbondy
Merge pull request #599 from pilgrim-brave/whitelist
8be69fd 
Autoplay some sites in absence of explicit block rule
bbondy added a commit that referenced this pull request Oct 11, 2018
@bbondy
Merge pull request #599 from pilgrim-brave/whitelist
5742075 
Autoplay some sites in absence of explicit block rule
@bbondy
Copy link
Member

bbondy commented Oct 11, 2018

master: b9bebf0
0.56.x: 8be69fd
0.55.x: 5742075

This was referenced Oct 15, 2018
Closed
Closed
Closed
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Whitelist some sites to not block autoplay by default
2 participants
@pilgrim-brave @bbondy