Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widevine not being installed #1123

Closed
bbondy opened this issue Sep 13, 2018 · 1 comment · Fixed by brave/brave-core#500
Closed

Widevine not being installed #1123

bbondy opened this issue Sep 13, 2018 · 1 comment · Fixed by brave/brave-core#500
Assignees
@bbondy
Labels
OS/macOS OS/Windows plugin/Widevine QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Sep 13, 2018 •
edited
Loading

Because the request goes to the component update server as part of other requests, so it is never handled. There's a restriction to only forward things that are 1 extension at a time to the chrome store.

For licensing reasons we can't host this ourselves.

Note to QA: Just basically make sure Netflix works.
@bbondy bbondy added this to the Releasable builds 0.55.x milestone Sep 13, 2018
@bbondy bbondy self-assigned this Sep 13, 2018
bbondy added a commit to brave/brave-core that referenced this issue Sep 26, 2018
@bbondy
Force Widevine to do its own independent check so it goes to Google
79bd35f 
Fix brave/brave-browser#1123

Our newer component update server will try to handle any requests for extension updates that gets bundled with other extensions in the same request.
i.e. len(extensions_to_update) == 1 and unrecognized then go to google
server.

The old way this worked was batched with other extnesion update checks at the same time so we would just not return an update from our own server which handled it.

Note that other extensions use the newer component installer which we set as a batch size of 1 so general extension updates are not affected by this.
@bbondy bbondy mentioned this issue Sep 26, 2018
Merged
11 tasks
@bbondy bbondy added the QA/Yes label Sep 26, 2018
@btlechowski
Copy link

btlechowski commented Sep 27, 2018 •
edited by LaurenWags
Loading

Verification passes on

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows 7

Installed plugin through URL bar.
Checked Widevine Content Decryption Module version in chrome://components/
Played Netflix movies.

Verification passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Installed plugin through URL bar.
Checked Widevine Content Decryption Module version in chrome://components/
Played Netflix.

@jenix21 jenix21 mentioned this issue Aug 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
OS/macOS OS/Windows plugin/Widevine QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Force Widevine to do its own independent check so it goes to Google brave/brave-core
4 participants
@bbondy @srirambv @LaurenWags @btlechowski