Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Widevine to do its own independent check so it goes to Google #500

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 26, 2018

Fix brave/brave-browser#1123

For licensing reasons we need to go to Google for installing Widevine.

Our newer component update server will try to handle any requests for extension updates that gets bundled with other extensions in the same request.
i.e. len(extensions_to_update) == 1 and unrecognized then go to google
server.

The old way this worked was batched with other extnesion update checks at the same time so we would just not return an update from our own server which handled it.

Note that other extensions use the newer component installer which we set as a batch size of 1 so general extension updates are not affected by this.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Fix brave/brave-browser#1123

Our newer component update server will try to handle any requests for extension updates that gets bundled with other extensions in the same request.
i.e. len(extensions_to_update) == 1 and unrecognized then go to google
server.

The old way this worked was batched with other extnesion update checks at the same time so we would just not return an update from our own server which handled it.

Note that other extensions use the newer component installer which we set as a batch size of 1 so general extension updates are not affected by this.
@bbondy bbondy self-assigned this Sep 26, 2018
@bbondy bbondy requested a review from emerick September 26, 2018 13:45
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 3f547ff into master Sep 26, 2018
bbondy added a commit that referenced this pull request Sep 26, 2018
Force Widevine to do its own independent check so it goes to Google
@bbondy
Copy link
Member Author

bbondy commented Sep 26, 2018

master: 3f547ff
0.55.x: 5e54185

@bsclifton bsclifton deleted the widevine-install branch September 28, 2018 06:57
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Widevine not being installed
2 participants