Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pre-populated search engine list #13283

Closed
8 tasks done
bsclifton opened this issue Dec 22, 2020 · 3 comments · Fixed by brave/brave-core#7494
Closed
8 tasks done

Updated pre-populated search engine list #13283

bsclifton opened this issue Dec 22, 2020 · 3 comments · Fixed by brave/brave-core#7494
Assignees
@bsclifton @deeppandya
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.19.x - Release

Comments

@bsclifton
Copy link
Member

bsclifton commented Dec 22, 2020 •
edited
Loading

Description

Small update to the engines we show by default

  • Add Ecosia as an option for some markets:
    • USA (US)
    • UK (GB)
    • France (FR)
    • Germany (DE)
    • Netherlands (NL)
    • Belgium (BE)
    • Switzerland (CH)
    • Sweden (SE)
  • Remove Yahoo as an option (originally added with Updated pre-populated search engine list #10890)

Test plan

Verify changes in the Default search engines list

  1. Set locale to one of the supported locales (see list above)- for example US
  2. New profile
  3. Launch Brave, go through onboarding to search engine step. Verify:
    • Ecosia shows in list (should be towards the end)
    • Yahoo is NOT shown in list
  4. Open brave://settings/searchEngines in a new tab. Verify:
    • Ecosia shows in list (should be towards the end)
    • Yahoo is NOT shown in list
    • NOTE: Yahoo will still show on iOS; but not on Android or Desktop

Verify folks w/ Yahoo set don't lose their setting

  1. Using an older version of Brave which has Yahoo, set Yahoo as the default search engine
  2. Update to the new version of Brave with this fix
  3. Visit brave://settings/searchEngines
  4. Yahoo should still be shown under Default search engines (order may have changed; this is OK)
  5. Switch default to Ecosia
  6. Yahoo will still be listed in the search engine list

Verify the Ecosia referral IDs used are correct

  1. Do a search (on Android/Desktop/using Ecosia
  2. Verify tt= part of URL fragment matches referral code shown in https://github.com/brave/internal/wiki/Search-engine-integrations
@bsclifton bsclifton added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 22, 2020
@bsclifton bsclifton self-assigned this Dec 22, 2020
@bsclifton bsclifton mentioned this issue Dec 22, 2020
Merged
23 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Dec 28, 2020
@bsclifton
Add Ecosia as a default search alternative
61030fa 
Shown in the following markets:
USA (US), UK (GB), France (FR), Germany (DE), Netherlands (NL), Belgium (BE), Switzerland (CH), Sweden (SE)

Fixes brave/brave-browser#13283
@bsclifton bsclifton changed the title Add Ecosia as a search alternative in some markets Updated pre-populated search engine list Dec 28, 2020
@iccub iccub mentioned this issue Jan 5, 2021
Closed
bsclifton added a commit to brave/brave-core that referenced this issue Jan 6, 2021
@bsclifton
Add Ecosia as a default search alternative
15f18fa 
Shown in the following markets:
USA (US), UK (GB), France (FR), Germany (DE), Netherlands (NL), Belgium (BE), Switzerland (CH), Sweden (SE)

Fixes brave/brave-browser#13283
bsclifton added a commit to brave/brave-core that referenced this issue Jan 7, 2021
@bsclifton
Add Ecosia as a default search alternative
63afefd 
Shown in the following markets:
USA (US), UK (GB), France (FR), Germany (DE), Netherlands (NL), Belgium (BE), Switzerland (CH), Sweden (SE)

Fixes brave/brave-browser#13283
@bsclifton bsclifton added this to the 1.20.x - Nightly milestone Jan 7, 2021
bsclifton added a commit to brave/brave-core that referenced this issue Jan 8, 2021
@bsclifton
Add Ecosia as a default search alternative
49eed95 
Shown in the following markets:
USA (US), UK (GB), France (FR), Germany (DE), Netherlands (NL), Belgium (BE), Switzerland (CH), Sweden (SE)

Fixes brave/brave-browser#13283
@bsclifton bsclifton mentioned this issue Jan 11, 2021
Merged
4 tasks
@bsclifton bsclifton mentioned this issue Jan 12, 2021
Closed
15 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Jan 12, 2021
@bsclifton
Add Ecosia as a default search alternative
7537ee5 
Shown in the following markets:
USA (US), UK (GB), France (FR), Germany (DE), Netherlands (NL), Belgium (BE), Switzerland (CH), Sweden (SE)

Fixes brave/brave-browser#13283
@kjozwiak
Copy link
Member

kjozwiak commented Jan 14, 2021 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (x86_64)
--- | ---
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | macOS Version 11.1 (Build 20C69)

Case 1 - Verify changes in the Default search engines list

USA USA USA USA
Screen Shot 2021-01-13 at 10 33 12 PM Screen Shot 2021-01-13 at 10 30 39 PM Screen Shot 2021-01-13 at 10 30 54 PM Screen Shot 2021-01-13 at 10 31 03 PM
UK UK UK UK
Screenshot 2021-01-13 at 22 36 38 Screenshot 2021-01-13 at 22 36 50 Screenshot 2021-01-13 at 22 37 04 Screen Shot 2021-01-13 at 10 31 03 PM
Canada Canada Canada Canada
Screen Shot 2021-01-13 at 10 41 04 PM Screen Shot 2021-01-13 at 10 41 21 PM Screen Shot 2021-01-13 at 10 41 35 PM Screen Shot 2021-01-13 at 10 41 42 PM

Note: Ecosia shouldn't be appearing in Canada as it's not a supported region as per #13283 (comment)

France (Default Quant)` France (Default Quant)` France (Default Quant) France (Default Quant)`
Screenshot 2021-01-13 at 22 45 18 Screenshot 2021-01-13 at 22 44 29 Screenshot 2021-01-13 at 22 44 44 Screenshot 2021-01-13 at 22 44 53

Note: ensured that Qwant was still the default search engine in France

Germany (Default DDG)` Germany (Default DDG)` Germany (Default DDG) Germany (Default DDG)`
Screenshot 2021-01-13 at 22 47 23 Screenshot 2021-01-13 at 22 48 24 Screenshot 2021-01-13 at 22 48 36 Screenshot 2021-01-13 at 22 48 44

Note: ensured that DDG was still the default search engine in Germany

Netherlands Netherlands Netherlands Netherlands
Screenshot 2021-01-13 at 22 54 51 Screenshot 2021-01-13 at 22 54 45 Screenshot 2021-01-13 at 22 55 06 Screenshot 2021-01-13 at 22 55 12
Belgium Belgium Belgium Belgium
Screenshot 2021-01-13 at 23 45 29 Screenshot 2021-01-13 at 23 45 57 Screenshot 2021-01-13 at 23 46 11 Screenshot 2021-01-13 at 23 46 17
Switzerland Switzerland Switzerland Switzerland
Screenshot 2021-01-13 at 23 49 31 Screenshot 2021-01-13 at 23 49 44 Screenshot 2021-01-13 at 23 50 08 Screenshot 2021-01-13 at 23 50 14
Sweden Sweden Sweden Sweden
Screenshot 2021-01-13 at 23 54 11 Screenshot 2021-01-13 at 23 54 31 Screenshot 2021-01-13 at 23 54 46 Screenshot 2021-01-13 at 23 54 53

Case 2 - Verify folks w/ Yahoo set don't lose their setting

Case 1 - Canada

  • downloaded 1.18.78 CR: 87.0.4280.141 and set the default SE as Startpage
  • upgraded to 1.19.83 CR: 88.0.4324.79 and ensured that Startpage was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia wasn't being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that Yahoo was removed from both brave://settings/search & brave://settings/searchEngines

Case 2 - USA

  • downloaded 1.18.78 CR: 87.0.4280.141 and set the default SE as Yahoo
  • upgraded to 1.19.83 CR: 88.0.4324.79 and ensured that Yahoo was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia was being listed under brave://settings/search & brave://settings/searchEngines
    • ensured that Yahoo wasn't being removed from both brave://settings/search & brave://settings/searchEngines

Case 3 - France

  • downloaded 1.20.65 CR: 88.0.4324.51 and set the default SE as Qwant (Default)
  • upgraded to 1.20.73 CR: 88.0.4324.79 and ensured that Qwant was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia was being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that Yahoo was removed from both brave://settings/search & brave://settings/searchEngines

Case 3 - Verify the Ecosia referral IDs used are correct

Searched via the omnibox when Ecosia was set as the default search engine and ensured that tt=e8eb07a6 as per https://github.com/brave/internal/wiki/Search-engine-integrations

Ensured that directly going to Ecosia and initiating a search doesn't use the referral code as per the following:

Verification passed on

Brave 1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
Revision bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS Ubuntu 18.04 LTS

Case 1 - Verify changes in the Default search engines list

USA USA USA
image image image
UK UK UK
image image image
Canada Canada Canada
image image image

Note: Ecosia shouldn't be appearing in Canada as it's not a supported region as per #13283 (comment)

France (Default Quant)` France (Default Quant)` France (Default Quant)
image image image

Note: ensured that Qwant was still the default search engine in France

Germany (Default DDG)` Germany (Default DDG)` Germany (Default DDG)
image image image

Note: ensured that DDG was still the default search engine in Germany

Netherlands Netherlands Netherlands
image image image

Ecosia not added. Logged #13571

Belgium Belgium Belgium
image image image

Ecosia not added. Logged #13571

Switzerland Switzerland Switzerland
image image image
Sweden Sweden Sweden
image image image

Ecosia not added. Logged #13571

Case 2 - Verify folks w/ Yahoo set don't lose their setting

Case 1 - Canada

  • downloaded 1.18.78 CR: 87.0.4280.141 and set the default SE as Startpage
  • upgraded to 1.19.83 CR: 88.0.4324.79 and ensured that Startpage was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia wasn't being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that Yahoo was removed from both brave://settings/search & brave://settings/searchEngines

Case 2 - USA

  • downloaded 1.18.78 CR: 87.0.4280.141 and set the default SE as Yahoo
  • upgraded to 1.19.83 CR: 88.0.4324.79 and ensured that Yahoo was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia was being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that Yahoo wasn't being removed from both brave://settings/search & brave://settings/searchEngines
    image

Case 3 - France

  • downloaded 1.20.65 CR: 88.0.4324.51 and set the default SE as Qwant (Default)
  • upgraded to 1.20.73 CR: 88.0.4324.79 and ensured that Qwant was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia was being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that Yahoo was removed from both brave://settings/search & brave://settings/searchEngines
    image

Case 3 - Verify the Ecosia referral IDs used are correct

Searched via the omnibox when Ecosia was set as the default search engine and ensured that tt=e8eb07a6 as per https://github.com/brave/internal/wiki/Search-engine-integrations

Encountered #13568

Ensured that directly going to Ecosia and initiating a search doesn't use the referral code as per the following:

Verification passed on


Brave | 1.19.85 Chromium: 88.0.4324.89 (Official Build) (64-bit)
-- | --
Revision | 4534be84786f5269fb52e9bf82643af61e2fedaf-refs/branch-heads/4324@{#1721}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Case 1 - Verify changes in the Default search engines list

USA USA USA USA
image image image image
UK UK UK UK
image image image image
Canada Canada Canada Canada
image image image image
France (Default Quant)` France (Default Quant)` France (Default Quant) France (Default Quant)`
image image image image

Note: ensured that Qwant was still the default search engine in France

Germany (DDG)` Germany (DDG)` Germany (DDG) Germany (DDG)`
image image image image

Note: ensured that DDG was still the default search engine in Germany

Netherland Netherland Netherland Netherland
image image image image
Belgium Belgium Belgium Belgium
image image image image
Switzerland Switzerland Switzerland Switzerland
image image image image
Sweden Sweden Sweden Sweden
image image image image

Case 2 - Verify folks w/ Yahoo set don't lose their setting

Case 1 - Canada

  • downloaded 1.18.78 CR: 87.0.4280.141 and set the default SE as Startpage
  • upgraded to 1.19.85 CR: 88.0.4324.89 and ensured that Startpage was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia wasn't being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that Yahoo was removed from both brave://settings/search & brave://settings/searchEngines

Case 2 - USA

  • downloaded 1.18.78 CR: 87.0.4280.141 and set the default SE as Yahoo
  • upgraded to 1.19.85 CR: 88.0.4324.89 and ensured that Yahoo was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia was being listed under brave://settings/search & brave://settings/searchEngines
    • ensured that Yahoo wasn't being removed from both brave://settings/search & brave://settings/searchEngines

Case 3 - France

  • downloaded 1.18.78 CR: 87.0.4280.141 and set the default SE as Qwant (Default)
  • upgraded to 1.19.85 CR: 88.0.4324.89 and ensured that Qwant was still set as the default SE
    • checked both brave://settings/search & brave://settings/searchEngines
  • ensured that Ecosia was being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that Yahoo was removed from both brave://settings/search & brave://settings/searchEngines

Case 3 - Verify the Ecosia referral IDs used are correct

Searched via the omnibox when Ecosia was set as the default search engine and ensured that tt=e8eb07a6 as per https://github.com/brave/internal/wiki/Search-engine-integrations

Ensured that directly going to Ecosia and initiating a search doesn't use the referral code as per the following:

Additional testing on Ecosia is covered in #13568 (comment)

@kjozwiak
Copy link
Member

Found #13568 during QAing with @srirambv, We'll get this fixed and uplifted but in the meantime, can finish the remaining cases 👍 Once #13568 has been fixed, we can quickly check if { } are removed. Shouldn't block QA on the above cases.

@srirambv
Copy link
Contributor

srirambv commented Jan 14, 2021 •
edited
Loading

Verification passed on OnePlus 6T with Android 10 running 1.19.83 x64 build

Scenario 1 - Verify changes in the Default search engines list

  • Verified Ecosia is present Search engine onboarding list and listed in Standard tab search engine list and Private Tab search engine list
USA (Onboarding) USA (Standard Tab SE list) USA (Private Tab SE list)
image image image
France (Onboarding) France (Standard Tab SE list) France (Private Tab SE list)
image image image
Belgium (Onboarding) Belgium (Standard Tab SE list) Belgium (Private Tab SE list)
image image image
  • Verified Ecosia is not listed for default search engine for unsupported regions like Japan
Japan (Onboarding) Japan (Standard Tab SE list) Japan (Private Tab SE list)
image image image

Scenario 2 - Verify folks w/ Yahoo set don't lose their setting

  • Verified installing 1.18.78 and setting Yahoo as default and upgrading to 1.19.83 retains Yahoo as default SE
  • Verified setting Yahoo as default on 1.18.78 and upgrading to 1.19.83 adds Ecosia to the list of default SE
  • Verified setting Yahoo as default on 1.18.78 and upgrading to 1.19.83 and changing default to Ecosia doesn't lose Yahoo from the list

Scenario 3 - Verify the Ecosia referral IDs used are correct

  • Verified searching via URL bar with Ecosia set as default SE, tt=42b8ae98 is appended to the search URL
    image
  • Verified visiting https://ecosia.org and performing a search doesn't append the refcode
    image

Verification passed on Samsung Tab A with Android 10 running 1.19.83 x64 build

Scenario 1 - Verify changes in the Default search engines list

  • Verified Ecosia is present Search engine onboarding list and listed in Standard tab search engine list and Private Tab search engine list
USA (Onboarding) USA (Standard Tab SE list) USA (Private Tab SE list)
image image image
France (Onboarding) France (Standard Tab SE list) France (Private Tab SE list)
image image image
Belgium (Onboarding) Belgium (Standard Tab SE list) Belgium (Private Tab SE list)
image image image
  • Verified Ecosia is not listed for default search engine for unsupported regions like Japan
Japan (Onboarding) Japan (Standard Tab SE list) Japan (Private Tab SE list)
image image image

Scenario 2 - Verify folks w/ Yahoo set don't lose their setting

  • Verified installing 1.18.78 and setting Yahoo as default and upgrading to 1.19.83 retains Yahoo as default SE
  • Verified setting Yahoo as default on 1.18.78 and upgrading to 1.19.83 adds Ecosia to the list of default SE
  • Verified setting Yahoo as default on 1.18.78 and upgrading to 1.19.83 and changing default to Ecosia doesn't lose Yahoo from the list

Scenario 3 - Verify the Ecosia referral IDs used are correct

  • Verified searching via URL bar with Ecosia set as default SE, tt=42b8ae98 is appended to the search URL
    image

  • Verified visiting https://ecosia.org and performing a search doesn't append the refcode
    image

Encountered #13568 on Android as well

@btlechowski btlechowski mentioned this issue Jan 14, 2021
Open
@kjozwiak kjozwiak mentioned this issue Jan 19, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.19.x - Release
Development

Successfully merging a pull request may close this issue.

Search engine updates brave/brave-core
6 participants
@kjozwiak @bsclifton @deeppandya @srirambv @btlechowski @GeetaSarvadnya