Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated pre-populated search engine list #10890

Closed
bsclifton opened this issue Jul 24, 2020 · 1 comment · Fixed by brave/brave-core#6201
Closed

Updated pre-populated search engine list #10890

bsclifton opened this issue Jul 24, 2020 · 1 comment · Fixed by brave/brave-core#6201
Assignees
@bsclifton @deeppandya
Labels
feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.12.x - Release #1

Comments

@bsclifton
Copy link
Member

bsclifton commented Jul 24, 2020 •
edited
Loading

Description

Small update to the engines we show by default

  • Add Yahoo as an option
  • Remove DDG Lite on Android
  • Add ability to localize engine based on country code

Related: https://github.com/brave/internal/issues/701, https://github.com/brave/internal/issues/700

Test plan (Desktop)

Verify Yahoo shows as an option in onboarding

  1. Fresh profile
  2. Launch Brave and go through on-boarding wizard (brave://welcome)
  3. Confirm Yahoo shows in drop down as first item on search engine screen
  4. Confirm default is what it should be (Google for USA, DDG for DE/IE/NZ/AU)

Verify Yahoo shows in brave://settings/

  1. Fresh profile
  2. Launch Brave and visit brave://settings/searchEngines
  3. Confirm Yahoo shows as the first item under Default search engines
  4. Confirm default is what it should be (Google for USA, DDG for DE/IE/NZ/AU)

Verify Yahoo localizes itself

Quick overview of how to change locale (Windows 10)

  • Open settings (bottom right corner)
  • Pick Time & Language
  • On the left side-menu, pick Region
  • Change Country or Region:
    image

Verify locale specific version of Yahoo URL is used in supported region

  1. Set country for your OS as one which supports Yahoo (USA, Argentina, Austria, Australia, Brasil, Canada, Switzerland, Chile, Colombia, Germany, Denmark, Spain, Finland, France, Hong Kong, Indonesia, Republic of Ireland, India, Italy, Mexico, Malaysia, Netherlands, Norway, New Zealand, Peru, Philippines, Sweden, Singapore, Thailand, Taiwan, Great Britain / England / etc, Venezuela, Vietnam)
  2. Fresh profile
  3. Launch Brave and visit brave://settings/searchEngines
  4. Inspect the Yahoo link and verify it's using the proper localized version (ex: mx.search.yahoo.com for Mexico)

Verify Yahoo is not shown in unsupported region

  1. Set country for your OS as one which doesn't support Yahoo (Japan, Turkey, Russia, etc)
  2. Fresh profile
  3. Launch Brave and visit brave://settings/searchEngines
  4. Yahoo shouldn't show in list under Default search engines

Verify Yahoo searches show in P3A dashboard

See https://github.com/brave/internal/issues/704

  1. Do searches in omnibox with Yahoo as the default
  2. Open brave://local-state and look for Brave.Search.DefaultEngine.2
  3. There should be a value of 6

Test plan (Android)

Verify Yahoo shows as an option in onboarding

  1. Fresh install
  2. Launch Brave and tap on search bar. it should open the onboarding
  3. Confirm Yahoo shows in list as first item on search engine onboarding

Verify Yahoo shows in settings

  1. Fresh install or update
  2. Launch Brave and go to settings
  3. Confirm Yahoo shows as the first item under Standard Tab and Private Tab

Verify DuckDuckGo Lite is removed

  1. Fresh install
  2. Launch Brave and tap on search bar. it should open the onboarding
  3. Confirm DuckDuckGo Lite is NOT in search engine onboarding
  4. Go to settings
  5. Confirm DuckDuckGo Lite is NOT shown as an option
@bsclifton bsclifton added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop labels Jul 24, 2020
@bsclifton bsclifton added this to the 1.13.x - Nightly milestone Jul 24, 2020
@bsclifton bsclifton mentioned this issue Jul 24, 2020
Merged
32 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Jul 28, 2020
@bsclifton
Adding Yahoo as an option
371e694 
Yahoo using SYC (search.yahoo.com) is split by region. Placeholders
created for most regions.

Fixes brave/brave-browser#10890
@deeppandya deeppandya mentioned this issue Jul 29, 2020
Merged
4 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Aug 3, 2020
@bsclifton
Adding Yahoo as an option
feb6a8b 
Yahoo using SYC (search.yahoo.com) is split by region. Placeholders
created for most regions.

Fixes brave/brave-browser#10890
@srirambv srirambv mentioned this issue Aug 5, 2020
Closed
@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Aug 5, 2020
@rebron rebron changed the title Search updates Search engine updates Aug 10, 2020
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Aug 10, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Aug 11, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave	1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision	a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from the description

Onboarding:

  • Confirmed Google is the default in USA but Yahoo can be selected in onboarding.
  • Confirmed DDG is the default in DE/IE/NZ/AU but Yahoo can be selected in onboarding.
  • Confirmed after selecting Yahoo in onboarding the appropriate localized Yahoo is used in DE/IE/NZ/AU (confirmed in settings and by doing a search via URL bar).

brave://settings/searchEngines:

  • Confirmed placement of Yahoo.
  • Confirmed correct localized Yahoo URL is listed.
  • Confirmed correct default of Google is set in US on clean profile.
  • Confirmed correct default of DDG is set in DE/IE/NZ/AU on clean profiles.

Localization (supported regions):

  • Confirmed Yahoo URL is listed and localized for Norway in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Sweden in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Thailand in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Switzerland in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Colombia in brave://settings/searchEngines.

Unsupported regions:

  • Confirmed Yahoo URL is not listed for Japan in brave://settings/searchEngines.
  • Confirmed Yahoo URL is not listed for Turkey in brave://settings/searchEngines.
  • Confirmed Yahoo URL is not listed for Russia in brave://settings/searchEngines.

P3A:

  • Confirmed expected P3A value in brave://local-state
         "Brave.Search.DefaultEngine.2": {
            "sent": false,
            "value": "6"
         },

Verification is in progress


Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Verified test plan from the description

Onboarding:

  • Confirmed Google is the default in USA but Yahoo can be selected in onboarding.
  • Confirmed DDG is the default in DE/IE/NZ/AU but Yahoo can be selected in onboarding.
  • Confirmed after selecting Yahoo in onboarding the appropriate localized Yahoo is used in DE/IE/NZ/AU (confirmed in settings and by doing a search via URL bar).

brave://settings/searchEngines:

  • Confirmed placement of Yahoo.
  • Confirmed correct localized Yahoo URL is listed.
  • Confirmed correct default of Google is set in US on clean profile.
  • Confirmed correct default of DDG is set in DE/IE/NZ/AU on clean profiles.

Localization (supported regions):

  • Confirmed Yahoo URL is listed and localized for Netherland in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Austria in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Austalia in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Italy in brave://settings/searchEngines.

Unsupported regions:

  • Confirmed Yahoo URL is not listed for South Africa in brave://settings/searchEngines.
  • Confirmed Yahoo URL is not listed for Turkey in brave://settings/searchEngines.
  • Confirmed Yahoo URL is not listed for Russia in brave://settings/searchEngines.

P3A:

"Brave.Search.DefaultEngine.2": {
            "sent": false,
            "value": "6"
         },

Verified test plan from the description

Onboarding:

  • Confirmed Google is the default in USA but Yahoo can be selected in onboarding.
  • Confirmed DDG is the default in DE/IE/NZ/AU but Yahoo can be selected in onboarding.
  • Confirmed after selecting Yahoo in onboarding the appropriate localized Yahoo is used in DE/IE/NZ/AU (confirmed in settings and by doing a search via URL bar).

brave://settings/searchEngines:

  • Confirmed placement of Yahoo.
  • Confirmed correct localized Yahoo URL is listed.
  • Confirmed correct default of Google is set in US on clean profile.
  • Confirmed correct default of DDG is set in DE/IE/NZ/AU on clean profiles.

Localization (supported regions):

  • [FAILED] Confirmed Yahoo URL is listed and localized for Sweden (sv_SE) in brave://settings/searchEngines.
    image
  • Confirmed Yahoo URL is listed and localized for France(fr_FR) in brave://settings/searchEngines.
  • Confirmed Yahoo URL is listed and localized for Spain (es_ES) in brave://settings/searchEngines.
  • [FAILED] Confirmed Yahoo URL is listed and localized for Finland(fi_FI) in brave://settings/searchEngines.
    image

Unsupported regions:

  • Confirmed Yahoo URL is not listed for Poland (pl_PL) in brave://settings/searchEngines.
  • Confirmed Yahoo URL is not listed for Czech Republic (cs_CZ) in brave://settings/searchEngines.
  • Confirmed Yahoo URL is not listed for Danish (da_DA)in brave://settings/searchEngines.

P3A:

"Brave.Search.DefaultEngine.2": {
	"sent": true,
	"timestamp": 1597170038.916757,
	"value": "6"
},

This was referenced Aug 11, 2020
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Aug 11, 2020
Closed
@btlechowski btlechowski mentioned this issue Aug 11, 2020
Closed
@bsclifton bsclifton changed the title Search engine updates Updated pre-populated search engine list Aug 11, 2020
@bsclifton bsclifton mentioned this issue Dec 28, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

@deeppandya deeppandya

Labels
feature/search OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging a pull request may close this issue.

Search updates brave/brave-core
8 participants
@kjozwiak @bsclifton @deeppandya @rebron @srirambv @LaurenWags @btlechowski @GeetaSarvadnya