Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out Olytics' tracking from URLs #13644

Closed
fmarier opened this issue Jan 19, 2021 · 2 comments · Fixed by brave/brave-core#7651
Closed

Filter out Olytics' tracking from URLs #13644

fmarier opened this issue Jan 19, 2021 · 2 comments · Fixed by brave/brave-core#7651

Comments

@fmarier
Copy link
Member

fmarier commented Jan 19, 2021

Olytics uses the following query string parameters in URLs to track individual users:

  • oly_anon_id
  • oly_enc_id

Here's are some examples found in the wild:

  • https://redmondmag.com/articles/2020/10/28/microsoft-privacy-platform-name-change.aspx?oly_enc_id=5335D7808612E8Z&m=1
  • https://www.pcimag.com/articles/107610-megafarma-to-distribute-basf-monomers-in-mexico?oly_enc_id=6901B4579189I9A
  • https://www.talentcanada.ca/statistics-on-covid-19-aid-provide-window-into-who-needed-help/?custnum&CUSTNUM%3B&title&%2AURLENCODE%28&TITLE%3B%29&utm_source&PUB_CODE%3B&utm_medium=email&utm_campaign&%2AURLENCODE%28%7B%7B%2AJobID%7D%7D%29&oly_enc_id=3681J7272256E9X
  • https://www.canadiangrocer.com/page/8?oly_anon_id=F-59d896a7-3426-45f9-9fb2-a351621d6d85&oly_enc_id=2026A2642790J9W
  • https://www.worktruckex.com/?oly_anon_id=59d896a7-3426-45f9-9fb2-a351621d6d85
@stephendonner
Copy link

stephendonner commented Feb 9, 2021

Verified FIXED using the testplan from brave/brave-core#7651, on:

Brave 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64)
Revision 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS macOS Version 11.2 (Build 20D64)
1) Open `https://brave.com/?oly_anon_id=1234` and confirm that there is no `oly_anon_id parameter` in the URL bar.

image

2) Open `https://brave.com/?oly_enc_id=1234` and confirm that there is no `oly_enc_id` parameter in the URL bar.
Screen Shot 2021-02-08 at 3 50 44 PM

Verification passed on

Brave 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified testplan from brave/brave-core#7651

Open `https://brave.com/?oly_anon_id=1234` and confirm that there is no `oly_anon_id parameter` in the URL bar.

image

Open `https://brave.com/?oly_enc_id=1234` and confirm that there is no `oly_enc_id` parameter in the URL bar.

image

Verified the examples from the description


Verified passed with

Brave	1.21.59 Chromium: 88.0.4324.182 (Official Build) beta (64-bit)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	Windows 10 OS Version 1909 (Build 18363.1256)
Open `https://brave.com/?WickedID=1234` and confirm that there is no `WickedID` parameter in the URL bar. Screen Shot 2021-02-18 at 3 21 25 PM
Open `https://brave.com/?oly_anon_id=1234` and confirm that there is no `oly_anon_id` parameter in the URL bar. Screen Shot 2021-02-18 at 3 22 26 PM
Open `https://brave.com/?oly_enc_id=1234` and confirm that there is no `oly_enc_id` parameter in the URL bar. Screen Shot 2021-02-18 at 3 23 29 PM

Verified the examples from the description as well.

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.21.69 x64 build

Verified links from test plan brave/brave-core/pull/7651
https://brave.com/?WickedID=1234 https://brave.com/?oly_anon_id=1234 https://brave.com/?oly_enc_id=1234
image image image
Links from issue description
image image image image image

Verification passed on Samsung Tab A with Android 10 running 1.21.69 x64 build

Verified links from test plan brave/brave-core/pull/7651
https://brave.com/?WickedID=1234 https://brave.com/?oly_anon_id=1234 https://brave.com/?oly_enc_id=1234
image image image
Links from issue description
image image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment