Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new query trackers #7650

Closed
wants to merge 2 commits into from
Closed

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Jan 19, 2021

Resolves brave/brave-browser#13644
Resolves brave/brave-browser#13647

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open https://brave.com/?WickedID=1234 and confirm that there is no WickedID parameter in the URL bar.
  2. Open https://brave.com/?oly_anon_id=1234 and confirm that there is no oly_anon_id parameter in the URL bar.
  3. Open https://brave.com/?oly_enc_id=1234 and confirm that there is no oly_enc_id parameter in the URL bar.

@fmarier fmarier added this to the 1.21.x - Nightly milestone Jan 19, 2021
@fmarier fmarier self-assigned this Jan 19, 2021
@fmarier
Copy link
Member Author

fmarier commented Jan 19, 2021

Superseded by #7651 which is using the right repo, not my personal fork.

@fmarier fmarier closed this Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter out Wicked Reports trackers from URLs Filter out Olytics' tracking from URLs
1 participant