Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing option to allow access to file URLs in PDFJS #1372

Closed
Brave-Matt opened this issue Oct 1, 2018 · 1 comment · Fixed by brave/brave-core#596
Closed

Missing option to allow access to file URLs in PDFJS #1372

Brave-Matt opened this issue Oct 1, 2018 · 1 comment · Fixed by brave/brave-core#596
Labels
browser-laptop-parity extension/PDFJS feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes

Comments

@Brave-Matt
Copy link

Description

In Brave Beta/Dev, the PDFJS config options are incomplete. In the "Details" section of the extension, the option to "Allow access to file URLs" option is missing. Setting this allows the browser to find/display pdf files stored locally in-browser.

When testing this on Chrome, navigating to the details section shows this option here:
image 1

Without this option available, all locally stored pdf files display in browser like so:
image

Steps to Reproduce

N/A

Actual result:

N/A

Expected result:

N/A

Reproduces how often:

Always

Brave version (chrome://version info)

Version 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes
  • Does it reproduce on browser-laptop? Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Is the issue reproducible on the latest version of Chrome? No

Additional Information

One (of many) user report of this behavior:
https://www.reddit.com/r/brave_browser/comments/9jghrb/brave_beta_now_available/e6zelyo/?context=3&utm_content=context&utm_medium=message&utm_source=reddit&utm_name=frontpage

@rebron rebron added feature/global-settings Settings at browser level independent of shields settings extension/PDFJS labels Oct 1, 2018
@rebron rebron added this to the 1.x Backlog milestone Oct 1, 2018
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. priority/P2 A bad problem. We might uplift this to the next planned release. browser-laptop-parity and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 5, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, Releasable builds 0.55.x Oct 10, 2018
@bbondy bbondy added the QA/Yes label Oct 10, 2018
bbondy added a commit to brave/brave-core that referenced this issue Oct 10, 2018
@LaurenWags
Copy link
Member

LaurenWags commented Oct 14, 2018

Verified passed with:

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Linux
  • Verified PDF is listed as a component in chrome://components and updated

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity extension/PDFJS feature/global-settings Settings at browser level independent of shields settings priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants