Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use component updater for installing PDF.js #596

Merged
merged 4 commits into from
Oct 10, 2018
Merged

Use component updater for installing PDF.js #596

merged 4 commits into from
Oct 10, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 10, 2018 •
edited
Loading

This test neither helps nor hurts the PDF.js intermittent failure that sometimes happens by the way.
I think that one just needs a longer test timeout default.

Note that after this change PDF.js won't show up in the extensions pane, only in chrome://components

Fix brave/brave-browser#1375
Fix brave/brave-browser#1253
Fix brave/brave-browser#1072
Fix brave/brave-browser#1372
Fix brave/brave-browser#1388

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy requested a review from emerick October 10, 2018 06:25
bbondy added 3 commits October 10, 2018 02:31
@bbondy
Install PDF.js from component updater
0f7eb50 
This also fixes a problem where PDF.js was not always installed.
This also fixes PDF.js disabling command line.
This also fixes intermittent PDF.js failures in tests.

Fix brave/brave-browser#1375
Fix brave/brave-browser#1253
Fix brave/brave-browser#1072
@bbondy
Allow file access for PDF.js
792b5c8 
Fix brave/brave-browser#1372
@bbondy
Hardcode PDF.js telemetry disabling
4cadca1 
Fix brave/brave-browser#1388
@bbondy bbondy self-assigned this Oct 10, 2018
emerick
emerick approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit a76b249 into master Oct 10, 2018
bbondy added a commit that referenced this pull request Oct 10, 2018
@bbondy
Merge pull request #596 from brave/pdf-js-take-2
1e22da3 
Use component updater for installing PDF.js
bbondy added a commit that referenced this pull request Oct 10, 2018
@bbondy
Merge pull request #596 from brave/pdf-js-take-2
c483b86 
Use component updater for installing PDF.js
@bbondy
Copy link
Member Author

bbondy commented Oct 10, 2018

master: a76b249
0.56.x: 1e22da3
0.55.x: c483b86

@NejcZdovc NejcZdovc deleted the pdf-js-take-2 branch October 10, 2018 13:19
@LaurenWags LaurenWags mentioned this pull request Oct 14, 2018
Closed
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
2 participants
@bbondy @emerick