-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System-notification ads don't auto-dismiss after click/landing, nor do they time-out #16357
Comments
Not reproducible on Ubuntu
|
Verified
Steps:
Confirmed ad was automatically dismissed, upon
Confirmed
Confirmed
Confirmed ad showed up on
Confirmed ads will time out after 120 seconds, without an explicit Verified passed with
Confirmed ad was automatically dismissed, upon
Confirmed
Confirmed
Confirmed ad showed up on
Confirmed ads will time out after 120 seconds, without an explicit
Verified
Confirmed ad was dismissed, upon Confirmed ad landed: [10988:12512:0621/133117.316:VERBOSE1:confirmations.cc(89)] Confirming landed ad for creative instance id 40f9f892-2eee-4b8f-8bde-45915ae2fd88 Confirmed
Confirmed
Confirmed ads will time out after 120 seconds, without an explicit
Confirmed ad showed up on
|
Description
System-notification ads don't auto-dismiss after click/landing, nor do they time-out
Steps to Reproduce
--enable-logging=stderr --vmodule="*/variations/*"=6,"*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=3
Actual result:
The system-ad notification never dismisses upon
click
, and doesn'ttime-out
either (as others do in 120 seconds?)It's also possible, in this state, to have stacked ad notifications.
Expected result:
Native/system-notification ad should dismiss upon successful
click
/land
, per @tmancey in Slack thread: https://bravesoftware.slack.com/archives/CJR5902AW/p1623281231116200Reproduces how often:
100%
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
/cc @btlechowski
The text was updated successfully, but these errors were encountered: