Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes system-notification ads don't auto-dismiss after click/landing, nor do they time-out #9160

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 17, 2021

Resolves brave/brave-browser#16357

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#16357

@tmancey tmancey requested a review from moritzhaller June 17, 2021 17:57
@tmancey tmancey self-assigned this Jun 17, 2021
@tmancey tmancey requested a review from yachtcaptain23 June 17, 2021 17:58
@kjozwiak
Copy link
Member

Looks like both #9164 & #9165 passed. Waiting on this to get merged so we can get a Nightly and verify before uplifting.

@tmancey
Copy link
Collaborator Author

tmancey commented Jun 18, 2021

CI failed for known unit test failure

@tmancey
Copy link
Collaborator Author

tmancey commented Jun 18, 2021

CI failed restarting

@tmancey tmancey merged commit e384691 into master Jun 18, 2021
@tmancey tmancey deleted the issues/16357 branch June 18, 2021 16:20
@tmancey tmancey added this to the 1.28.x - Nightly milestone Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System-notification ads don't auto-dismiss after click/landing, nor do they time-out
4 participants